Update logo to S. mark and add favicons#6
Draft
Tanops wants to merge 2 commits into
Draft
Conversation
- Replace sidebar gradient placeholder with the S. logo (SVG) - Add favicon.ico, SVG/PNG favicons, and apple-touch-icon - Update page title to Summon Co-authored-by: Tanops <Tanops@users.noreply.github.com>
|
The external assets/logo.svg img failed to load in some deployments (showing a broken image). Embed the S. mark directly in index.html so it always renders, use absolute /assets/ paths for favicons, and refine the mark typography. Co-authored-by: Tanops <Tanops@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the application branding to the new S. logo mark and adds a full set of favicons.
Changes
index.htmlso it always renders (fixes broken externalimgwhen assets were not resolved)favicon.ico,favicon.svg,favicon-16x16.png,favicon-32x32.png, andapple-touch-icon.pngunder/assets/Fix note
The initial implementation used
<img src="assets/logo.svg">, which showed a broken image in some environments. The logo is now embedded directly in the page markup for reliable display.Testing
npm test— all 26 tests pass