Skip to content

Reduce AX snapshot noise and exclude hidden content - #26

Open
RVZO6 wants to merge 3 commits into
SunkenInTime:mainfrom
RVZO6:fix/compact-accessibility-snapshots
Open

RVZO6 wants to merge 3 commits into
SunkenInTime:mainfrom
RVZO6:fix/compact-accessibility-snapshots

Conversation

@RVZO6

@RVZO6 RVZO6 commented Oct 9, 2026 •

Copy link
Copy Markdown

Bug

The synthesized accessibility tree includes script/style bodies and hidden content, and repeats large descendant text in container names. This produces noisy, oversized agent snapshots; a local Excel browser run exposed the same pattern.

Fix

Skip hidden subtrees and script/style nodes, suppress password values, emit visible text once as StaticText, and avoid assigning all descendant page text to generic containers. Preserve usable control names while recognizing H4–H6, aria-labelledby, native control roles, and open shadow roots.

Validation

  • pnpm test and the existing isolated Zen lifecycle test pass on this independent branch, including AX-node click/type/clear and screenshot/editor operations.
  • On the exact same fixture, the original collector produces 35,429 bytes and leaks the hidden script marker. The fixed collector produces 6,641 bytes, about 81% smaller, without the hidden/script/style/password markers.
  • The existing lifecycle test now checks those properties and verifies visible text is neither lost nor duplicated. No new test files or suites are added.

This validates the collector's improvement directly, rather than claiming a fresh end-to-end Excel agent run or complete native accessibility parity. Locator changes, the Chrome refresh, and native companion changes are not part of this PR; the companion remains unchanged.


Generated by GPT 6.1 Sol in Codex, using T3 Code.

RetriggerConfidence Score: 5/5

No outstanding blocking findings remain. The current code addresses the previously reported loss of word breaks in control names.

Summary

The PR reduces accessibility snapshot noise by skipping hidden subtrees, excluding script and style text, and withholding password values. It also keeps visible text and usable control names.

  • Firefox/Zen accessibility snapshots keep visible text and drop hidden noise.

Reviews (3) · Last reviewed commit: "Preserve rendered word boundaries in acc..." · Reviewed by Greptile

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4a8b6868-8f7e-4b1c-955b-99715791e9fd
📥 Commits

Reviewing files that changed from the base of the PR and between 634eddf and a3ea796.

📒 Files selected for processing (2)
  • extension/firefox-compat.js
  • tests/test-firefox-lifecycle-live.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread extension/firefox-compat.js Outdated
Comment thread extension/firefox-compat.js Outdated
Comment thread extension/firefox-compat.js Outdated
@RVZO6

RVZO6 commented Oct 9, 2026

Copy link
Copy Markdown
Author

Review fixes pushed in 3eba073.

All three review findings are addressed and their threads have replies/resolutions. Full npm test and npm run test:live pass in disposable headless Firefox 157.0.1. The real DOM regression covers visibility-restored descendants, assigned and empty-slot content, single traversal of assigned nodes, inline GitHub naming through the actual queryAXTree handler, and consistent AX parent/child links. The original collector fails the same fixture.

The updated changes are ready for another review; the latest review checks are still running.

Comment thread extension/firefox-compat.js Outdated
@greptile-apps

greptile-apps Bot commented Oct 9, 2026

Copy link
Copy Markdown

Want your agent to iterate on Greptile's feedback? Try greploops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant