Skip to content

Keep composer actions reachable in narrow native sidebars - #27

Open
RVZO6 wants to merge 2 commits into
SunkenInTime:mainfrom
RVZO6:fix/sidebar-host-sizing
Open

RVZO6 wants to merge 2 commits into
SunkenInTime:mainfrom
RVZO6:fix/sidebar-host-sizing

Conversation

@RVZO6

@RVZO6 RVZO6 commented Oct 9, 2026 •

Copy link
Copy Markdown

Bug

The sidebar's viewport-oriented sizing and non-shrinkable flex children can put composer actions outside the native host. At narrow widths, the secondary reasoning-effort label also competes with the remaining actions.

Fix

Use host-relative root/body height, keep flex children shrinkable, constrain the utility/footer areas, and hide only the secondary effort label in narrow composer containers. The model/effort remains available through the trigger's accessible name and menu. This stylesheet does not shrink fonts or disable zoom; the font cascade fix is separate.

Validation

  • pnpm test passes on this independent branch; assertions extend the existing bootstrap test rather than adding a layout suite.
  • A private one-off Zen smoke test renders the real refreshed composer components at 260, 320, 384, 438, and 600 CSS pixels, with the separate typography correction applied. All five actions remain within the host without overlapping, and the secondary effort label collapses at narrow widths.
  • Removing only this layout adapter from that smoke fixture reproduces the narrow-host failure. The one-off fixture is not added to the maintained repository tests.

The full responsive smoke uses the refreshed components plus the separate font fix; it is not an authenticated conversation test or a claim that the older vendor UI has identical geometry. This PR's source is otherwise independent of those changes. The native companion is unchanged.


Generated by GPT 6.1 Sol in Codex, using T3 Code.

RetriggerConfidence Score: 5/5

No outstanding findings block merging. The footer selector now reaches the shipped component.

Summary

The PR adds sidebar sizing rules and hides the secondary effort label in narrow composer containers.

  • Composer actions stay within narrow Firefox sidebars.

Reviews (2) · Last reviewed commit: "Apply host sizing to the shipped compose..." · Reviewed by Greptile

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9e47a3ad-f550-4006-baaf-846bfd4de675
📥 Commits

Reviewing files that changed from the base of the PR and between 634eddf and 64f0e7f.

📒 Files selected for processing (4)
  • extension/codex-sidepanel/firefox-sidebar-layout.css
  • extension/codex-sidepanel/index.html
  • tests/test-firefox-lifecycle-live.mjs
  • tests/test-sidepanel-bootstrap.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread extension/codex-sidepanel/firefox-sidebar-layout.css Outdated
@RVZO6

RVZO6 commented Oct 9, 2026

Copy link
Copy Markdown
Author

Review fixes pushed in 64f0e7f.

The footer-selector finding is addressed and its thread has a reply/resolution. Full npm test and npm run test:live pass in disposable headless Firefox 157.0.1. The maintained lifecycle test imports and renders the actual shipped ComposerFooter at 280/320/400px and verifies the CSS reaches it; it no longer relies on stylesheet-string assertions alone.

The updated changes are ready for another review; the latest review checks are still running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant