Repository navigation
Watch one player in the replay viewer - #309
Merged
Merged
Conversation
Reviewing a round usually means asking what one player was doing and what they could see. Now a player can be watched: click their agent on the map or their row in the roster, or press 1-0 (allies 1-5, enemies 6-0, as the roster lists them). Picking them again or Esc stops watching. While watching, only that player's view cone is drawn and cut (the frame leaves everyone else coneless, so a capture saves exactly the one cone on screen), everyone else is drawn at 55% opacity, and the camera glides in to at least 2x and keeps the player centred left of the roster. Panning by hand stops following without ending the watch; picking the player again follows them again. The watched roster row is raised and ringed in violet, and every row's tooltip says how to watch its player. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A canvas that never watched anyone made it in dispose, after its ticker mode was gone, and Flutter threw. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Swapping sides moves every player to the other block. Unkeyed, the rows stayed put and took on other players, and stopping a watch after a swap then closed the app on Windows (in the accessibility bridge, with a tool reading the window). Keyed by player, it doesn't. The watched agent is now drawn after everyone else, so a dimmed agent standing on them no longer hides them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewing a round usually starts with one player: what were they doing, and what could they see? VALORANT's own replay lets you jump into any player's eyes with 1–0, but no 2D viewer has an equivalent, including ours and ValoPlant's. Until now the viewer always showed all ten cones, and the only choice was which team's side to watch from.
What changed
How it was checked
test/replay_watch_test.dartcovers:ci: analyze test
🤖 Generated with Claude Code