Skip to content

perf(video): hand off decoded frames by reference - #349

Merged
ReenigneArcher merged 2 commits into
masterfrom
codex/video-frame-handoff
Nov 18, 2026
Merged

ReenigneArcher merged 2 commits into
masterfrom
codex/video-frame-handoff

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Description

Pass decoded FFmpeg frame buffers to the streaming renderer by reference. Screenshots retain a reference to the rendered frame while the capture worker runs.

  • Add Settings → Display → Video Presentation. Software presentation is the default, and GPU presentation uses the NV2A overlay with automatic software fallback.
  • Default new installations to 640×480 at 60 FPS and 3 Mbps. Explicit saved settings take precedence.
  • Keep the current H.264 decoder and the common-library revision from master. Additional codec negotiation is tracked in feat(video): add selectable video codecs #194.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • All 468 native tests passed with the locked dependencies in the isolated master-based checkout.
  • The repository formatter, CMake lint, strict API docs build, and patch whitespace check passed.
  • The clean MinGW64 release build packaged the Xbox application ISO and both opt-in video experiment ISOs.
  • xemu played two prerecorded 640×480, 60 FPS H.264 clips through both GPU and software presentation using the standalone release objects. The guest also verified that a retained frame remains readable after exchanging and releasing the presentation slot.
  • Verified that the prepared codec commit replays after a simulated squash merge. The resulting project tree matches the saved combined changes with the Lucide lock from current master.
  • Physical Xbox and live Sunshine validation remain pending.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@ReenigneArcher
ReenigneArcher marked this pull request as ready for review November 18, 2026 16:03
@codecov

codecov Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.84%. Comparing base (698fa95) to head (54ebb67).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/streaming/video_acceleration.cpp 55.55% 1 Missing and 3 partials ⚠️
src/app/client_state.cpp 85.71% 0 Missing and 3 partials ⚠️
src/app/settings_storage.cpp 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   73.82%   73.84%   +0.01%     
==========================================
  Files          68       68              
  Lines        7897     7922      +25     
  Branches     3452     3464      +12     
==========================================
+ Hits         5830     5850      +20     
- Misses       1090     1091       +1     
- Partials      977      981       +4     
Flag Coverage Δ
Linux 73.08% <81.81%> (+0.02%) ⬆️
macOS 62.38% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/app/client_state.h 98.63% <100.00%> (+0.03%) ⬆️
src/app/settings_storage.h 100.00% <100.00%> (ø)
src/streaming/video_acceleration.h 100.00% <100.00%> (ø)
src/app/settings_storage.cpp 77.33% <83.33%> (+0.04%) ⬆️
src/app/client_state.cpp 75.05% <85.71%> (+0.01%) ⬆️
src/streaming/video_acceleration.cpp 78.00% <55.55%> (-1.07%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 698fa95...54ebb67. Read the comment docs.

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit dbecb06 into master Nov 18, 2026
17 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/video-frame-handoff branch November 18, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant