Skip to content

feat(streaming): show launch progress and return to the app picker - #352

Merged
ReenigneArcher merged 2 commits into
masterfrom
codex/stream-startup-summary
Nov 19, 2026
Merged

ReenigneArcher merged 2 commits into
masterfrom
codex/stream-startup-summary

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Selecting an app could leave the app picker on screen while menu tasks finished and the host started the stream. Moonlight now shows a four-step progress dialog from menu preparation through the first video frame.

  • Let host discovery and status checks finish in the background. Cancel pending cover-art requests and retries while retaining covers that were already saved.
  • Log elapsed time for menu preparation, the host request, and first video presentation.
  • Show the stream summary over the app picker and dismiss it with A or Enter. Remove the separate stopping screen.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • Built the Xbox release ISO with cmake --build cmake-build-release --parallel 6.
  • Ran ctest --test-dir cmake-build-release --output-on-failure. All 481 tests passed, including artwork cancellation, startup progress, and summary confirmation.
  • Ran cmake --build cmake-build-release --target docs. The strict API documentation build passed.
  • In xemu, verified 720p60 Desktop resumes on the GPU and software paths, the app picker behind the summary, and Enter dismissing it without relaunching. In one local comparison with a host refresh in flight, time to first video fell from about 4.8 seconds to 1.5 seconds.
  • Original Xbox hardware was not tested.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.60870% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.08%. Comparing base (cacc3e5) to head (2d16529).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ui/shell_view.cpp 74.07% 0 Missing and 7 partials ⚠️
src/app/client_state.cpp 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   73.99%   74.08%   +0.08%     
==========================================
  Files          71       71              
  Lines        8029     8072      +43     
  Branches     3487     3503      +16     
==========================================
+ Hits         5941     5980      +39     
+ Misses       1097     1094       -3     
- Partials      991      998       +7     
Flag Coverage Δ
Linux 73.35% <80.43%> (+0.09%) ⬆️
macOS 62.62% <68.29%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/app/client_state.h 98.66% <ø> (ø)
src/network/host_pairing.cpp 46.66% <100.00%> (+0.39%) ⬆️
src/network/host_pairing.h 0.00% <ø> (ø)
src/ui/shell_view.h 20.00% <ø> (ø)
src/app/client_state.cpp 75.14% <92.85%> (+0.12%) ⬆️
src/ui/shell_view.cpp 72.68% <74.07%> (+0.01%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cacc3e5...2d16529. Read the comment docs.

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 3c6d0b0 into master Nov 19, 2026
17 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/stream-startup-summary branch November 19, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant