Skip to content

fix(packaging): inline single-use Homebrew formula helpers - #6128

Merged
ReenigneArcher merged 3 commits into
masterfrom
codex/fix-homebrew-single-use-methods
Nov 18, 2026
Merged

ReenigneArcher merged 3 commits into
masterfrom
codex/fix-homebrew-single-use-methods

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Description

Homebrew's new Homebrew/SingleUseMethod cop rejects 20 helpers in the generated Sunshine formula, failing Homebrew validation on Linux and macOS. Inline those helpers at their call sites and document the updated build, test, and coverage entry points while preserving compiler selection, CMake arguments, installed test fixtures, and coverage export.

The formula keeps test configuration and fixture installation in separate helpers to satisfy SonarCloud. Linux passes only MarkupSafe and Jinja2 to pip. The generated bottle block declares the registry root, and Homebrew adds checksums when it builds and merges bottles.

The tap-wide style fix is already merged. The Boost 1.89 backport in the tap applies to its pinned stable release. Sunshine’s generated formula uses the current source and its compatible Boost dependency. Companion tap PR

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • Reproduced 20 Homebrew/SingleUseMethod violations on the original formula.
  • CMake formula generation, Ruby syntax, and the full 8-file brew style check passed in WSL Ubuntu 24.04. The style check used the generated formula alongside the merged tap’s beta formula.
  • Executed the generated formula through Linux build setup. MarkupSafe and Jinja2 installed and imported in the virtualenv, and the formula passed the expected Python and coverage arguments to CMake.
  • brew bottle --merge --write --no-commit added a sample checksum to a scratch copy with the GHCR root and with a separate test-bot root.
  • uv sync --locked and git diff --check passed.
  • Full platform bottle builds and coverage jobs run in hosted CI.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

AI assisted with the formula refactor, validation, and this description.

This pull request was generated by Codex (GPT-6; thinking level not exposed by this session).

Copy link
Copy Markdown
Member Author

This pull request was generated by Codex (GPT-6; thinking level not exposed by this session).

@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 1.48kB (-0.15%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 999.72kB -1.48kB (-0.15%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
images/logo-*.svg (Deleted) -1.48kB 0 bytes -100.0% 🗑️

@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.20%. Comparing base (5cd21f3) to head (5bda25d).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6128      +/-   ##
==========================================
+ Coverage   43.87%   51.20%   +7.32%     
==========================================
  Files         146      148       +2     
  Lines       31261    32552    +1291     
  Branches    13302    13742     +440     
==========================================
+ Hits        13716    16667    +2951     
- Misses      13037    14230    +1193     
+ Partials     4508     1655    -2853     
Flag Coverage Δ
Alpine-aarch64 34.53% <ø> (+<0.01%) ⬆️
Alpine-x86_64 34.65% <ø> (ø)
Archlinux 35.52% <ø> (+0.01%) ⬆️
FreeBSD-amd64 35.43% <ø> (ø)
Homebrew-macos-15 48.96% <ø> (?)
Homebrew-macos-26 49.34% <ø> (?)
Homebrew-ubuntu-24.04 37.89% <ø> (?)
Linux-AppImage-aarch64 40.61% <ø> (-0.02%) ⬇️
Linux-AppImage-x86_64 40.86% <ø> (?)
PowerShell 100.00% <ø> (ø)
Web-UI 57.76% <ø> (ø)
Windows-AMD64 41.51% <ø> (ø)
Windows-ARM64 35.41% <ø> (-0.01%) ⬇️
macOS-arm64 41.70% <ø> (ø)
macOS-x86_64 40.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 66 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd21f3...5bda25d. Read the comment docs.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Last Updated 2026-11-18 01:01:25 UTC
Source Run CI Run #6832
Commit 5bda25d7148847688f1d30194da4bc323054cedb

Screenshot Comparison

PR #6128 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 37ee7d5 into master Nov 18, 2026
83 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-homebrew-single-use-methods branch November 18, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant