You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(packaging): inline single-use Homebrew formula helpers - #6128
Homebrew's new Homebrew/SingleUseMethod cop rejects 20 helpers in the generated Sunshine formula, failing Homebrew validation on Linux and macOS. Inline those helpers at their call sites and document the updated build, test, and coverage entry points while preserving compiler selection, CMake arguments, installed test fixtures, and coverage export.
The formula keeps test configuration and fixture installation in separate helpers to satisfy SonarCloud. Linux passes only MarkupSafe and Jinja2 to pip. The generated bottle block declares the registry root, and Homebrew adds checksums when it builds and merges bottles.
The tap-wide style fix is already merged. The Boost 1.89 backport in the tap applies to its pinned stable release. Sunshine’s generated formula uses the current source and its compatible Boost dependency. Companion tap PR
Reproduced 20 Homebrew/SingleUseMethod violations on the original formula.
CMake formula generation, Ruby syntax, and the full 8-file brew style check passed in WSL Ubuntu 24.04. The style check used the generated formula alongside the merged tap’s beta formula.
Executed the generated formula through Linux build setup. MarkupSafe and Jinja2 installed and imported in the virtualenv, and the formula passed the expected Python and coverage arguments to CMake.
brew bottle --merge --write --no-commit added a sample checksum to a scratch copy with the GHCR root and with a separate test-bot root.
uv sync --locked and git diff --check passed.
Full platform bottle builds and coverage jobs run in hosted CI.
Type of Change
feat: New feature (non-breaking change which adds functionality)
fix: Bug fix (non-breaking change which fixes an issue)
docs: Documentation only changes
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
refactor: Code change that neither fixes a bug nor adds a feature
perf: Code change that improves performance
test: Adding missing tests or correcting existing tests
build: Changes that affect the build system or external dependencies
ci: Changes to CI configuration files and scripts
chore: Other changes that don't modify src or test files
revert: Reverts a previous commit
BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)
Checklist
Code follows the style guidelines of this project
Code has been self-reviewed
Code has been commented, particularly in hard-to-understand areas
Code docstring/documentation-blocks for new or existing methods/components have been added or updated
Tests have been added or updated for new or modified functionality, including regression tests for bug fixes
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.20%. Comparing base (5cd21f3) to head (5bda25d).
✅ All tests successful. No failed tests found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Homebrew's new
Homebrew/SingleUseMethodcop rejects 20 helpers in the generated Sunshine formula, failing Homebrew validation on Linux and macOS. Inline those helpers at their call sites and document the updated build, test, and coverage entry points while preserving compiler selection, CMake arguments, installed test fixtures, and coverage export.The formula keeps test configuration and fixture installation in separate helpers to satisfy SonarCloud. Linux passes only MarkupSafe and Jinja2 to pip. The generated
bottleblock declares the registry root, and Homebrew adds checksums when it builds and merges bottles.The tap-wide style fix is already merged. The Boost 1.89 backport in the tap applies to its pinned stable release. Sunshine’s generated formula uses the current source and its compatible Boost dependency. Companion tap PR
Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
Homebrew/SingleUseMethodviolations on the original formula.brew stylecheck passed in WSL Ubuntu 24.04. The style check used the generated formula alongside the merged tap’s beta formula.brew bottle --merge --write --no-commitadded a sample checksum to a scratch copy with the GHCR root and with a separate test-bot root.uv sync --lockedandgit diff --checkpassed.Type of Change
Checklist
AI Usage
See our AI usage policy.
AI assisted with the formula refactor, validation, and this description.