Repository navigation
Conversation
Author
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Close four security boundaries identified during a manual source review.
origin_web_ui_allowedto initial credential creation, including installations with no username yet.The HTTPS lifetime regression test also exposed a synchronous TLS shutdown that could stall the HTTPS worker when a revoked peer withheld its close notification. Send the notification on a nonblocking socket before teardown.
Compatibility change — Clients must support encrypted RTSP (
corever >= 1). Older clients receive an update-client error. Current bundled Moonlight common-c advertisescorever=1. The setup and pairing documentation describes the new behavior.Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
Added regression tests for restricted first-run setup, certificate revocation and re-enable epochs, authenticated RTSP admission, real TLS keep-alive and concurrent client identity, malformed control envelopes, and real AES-GCM authentication failures and recovery.
Validated on Ubuntu 24.04 with GCC 13.3 and OpenSSL 3.0.13, using Xvfb and PulseAudio for platform tests.
uv sync --lockedsucceeded.uv run --locked lb-update-clang-formatsucceeded, andgit diff --checkpassed.sunshineandtest_sunshinewithBUILD_WERROR=ON../cmake-build-security/tests/test_sunshine --gtest_filter=-X11GrabTest.DisplayNamesRetryTransientScreenResourcesFailurecompleted with 858 passed and four skipped out of 862 cases.The excluded, unchanged X11 retry test fails under this Xvfb environment because the display list remains empty. The four skips cover Windows-specific support, the disabled tray, and unavailable NVENC/VAAPI encoders. Windows, macOS, physical capture devices, and hardware encoders were not exercised. Coverage reached 100% of executable lines in the new envelope parser. Changed-source line coverage is approximately 63%, with live stream callbacks and error paths remaining outside runtime coverage.
CMake used
BUILD_TESTS=ON,BUILD_DOCS=OFF,BUILD_WERROR=ON, andCMAKE_BUILD_TYPE=Debug. Tray, CUDA, DRM, VAAPI, Vulkan, Wayland, KWin, and portal backends were disabled. The follow-up documentation correction also passed the full strict Dockle build using Doxygen 1.18.0, generating 1,168 HTML pages.The follow-up quality-gate fix passed the same 862-case run (858 passed, four skipped) and both TLS revocation tests passed 20 consecutive repetitions. It also extends coverage for unknown clients and idempotent enable updates.
Type of Change
Checklist
AI Usage
See our AI usage policy.