Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly
pythonworkflow fails on all five Python versions withModuleNotFoundError: No module named 'deepspeed.moe.v2opt'whends_reportimports DeepSpeed (for example https://github.com/Supercomputing-System-AI-Lab/X-MoE/actions/runs/40053119642).deepspeed/moe/v2opt/has no__init__.py, sofind_packages(setup.py:320) skips it and a regularpip install .leaves out the 13 v2opt modules, even thoughdeepspeed/moe/sharded_moe.py:37imports.v2opt.gating. An editable install (pip install -e ., as in the README) still works because Python finds the directory as a namespace package, which is why this doesn't show up in a development checkout.This adds the same empty
__init__.pythat the liheng/GroupedGEMM, ELMoE, X-MoE-4D, zixian/pp_dev and zixian/shared_exp_impl branches already have, so merging those branches later won't conflict.Tests
pip install .[dev,autotuning]on Python 3.12: before,ds_reportfails with the error above. After, all 13 v2opt modules are installed, and with triton presentds_reportandimport deepspeed.moe.v2opt.gatingwork.pythonworkflow on my fork: master fails on all five versions with the same error (https://github.com/konstde00/X-MoE/actions/runs/40109822074). This branch passes on 3.11 and 3.12, and 3.8 to 3.10 stop at the triton import described below (https://github.com/konstde00/X-MoE/actions/runs/40109820064).On 3.8, 3.9 and 3.10 the job now stops at
No module named 'triton', because the v2opt kernels import triton and thegh-builderimages for those versions ship torch 1.12.1 without it.cpu-torch-latestinstalls CPU torch, so it stops at the same import (and would then hit its--torch_ver="2.5"check). I didn't touch these here, since whether to drop old Python versions from CI or guard the triton import is your call.