Fix mise initialization and remove stale build trigger#3
Merged
Conversation
Entire-Checkpoint: 6f6c8c10f88d
Entire-Checkpoint: 01973fe0b3e5
Entire-Checkpoint: d2d092b18909
Syati
changed the title
There was a problem hiding this comment.
Pull request overview
This PR improves the container’s runtime environment initialization by ensuring mise is properly activated in interactive shells, fixing potential permission issues with mise’s data directories during entrypoint execution, and removing an outdated GitHub Actions build trigger path.
Changes:
- Activate
miseduring shell initialization when available. - Ensure
/home/agent/.local/share/miseexists (and is owned byagent) before dropping root privileges in the entrypoint. - Remove a stale workflow path trigger (
compose.yml) from the image build workflow.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
docker/profile.sh |
Adds conditional mise activate during shell startup. |
docker/bin/agent-entrypoint |
Adds a startup step to create/chown mise directories before gosu drops to agent. |
.github/workflows/build-push.yml |
Removes a stale compose.yml path trigger from the build workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.