Repository navigation
Conversation
rust-le
force-pushed
the
feature/SY-842-notify-provider
branch
3 times, most recently
from
October 15, 2026 11:25
d3ed967 to
83d5011
Compare
rust-le
force-pushed
the
feature/SY-842-notify-provider
branch
from
October 16, 2026 06:36
83d5011 to
fe10368
Compare
rust-le
marked this pull request as ready for review
October 16, 2026 06:36
rust-le
force-pushed
the
feature/SY-842-notify-provider
branch
from
October 16, 2026 11:03
fe10368 to
7c35ef6
Compare
…ethod
Sylius' /payment-methods/{code} route now takes PayPal webhooks.
PayPalNotifyPaymentProvider verifies the signature with the webhook of the
method in the URL, not with the first PayPal method, and finds the payment by
the Payment Request hash PayPal was given as custom_id, then by the PayPal
order or capture id; the payment has to belong to that method. A signature it
cannot verify is answered 404 and an event about no payment of that method 204,
by PaymentMethodNotifyAction decorating the core action.
NotifyPaymentRequestHandler claims the event id in the processed-event store,
so a duplicate or parallel delivery changes nothing, reads the event's resource
again from PayPal with the method's credentials and hands it to the processor
registered for its event type; an event without one is recorded as ignored and
a permanent failure fails the Payment Request. The processors themselves come
in the next PR.
rust-le
force-pushed
the
feature/SY-842-notify-provider
branch
from
October 19, 2026 07:10
7c35ef6 to
fb247e0
Compare
GSadee
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin takes webhooks on its own
/paypal-webhook/api/endpoint, verifies every signature with the first PayPal payment method and finds the payment by the PayPal order id alone.Sylius'
/payment-methods/{code}notify route now takes PayPal webhooks too.PayPalNotifyPaymentProviderverifies the signature with the webhook of the method in the URL and finds the payment by the Payment Request hash PayPal was given ascustom_id, then by the PayPal order or capture id; the payment has to belong to that method. A signature it cannot verify is answered404, an event about no payment of that method204.NotifyPaymentRequestHandlerclaims the event id in the store from #813, so a duplicate or parallel delivery changes nothing, reads the event's resource again from PayPal and hands it to the processor tagged for its event type. The processors come in the next PR, so for now every event is recorded as ignored; the old endpoint is unchanged and PayPal keeps sending to it until the webhooks are re-registered.