Skip to content

Check the gateway of a refund Payment Request before processing it - #826

Merged
GSadee merged 1 commit into
Sylius:phase-2-payment-requestsfrom
rust-le:fix/refund-handlers-gateway-factory-check
Oct 20, 2026
Merged

GSadee merged 1 commit into
Sylius:phase-2-payment-requestsfrom
rust-le:fix/refund-handlers-gateway-factory-check

Conversation

@rust-le

@rust-le rust-le commented Oct 19, 2026

Copy link
Copy Markdown
Contributor
Q A
Branch? phase-2-payment-requests
Bug fix? yes
New feature? no
BC breaks? no
Related tickets SY-884, follow-up to #812

The refund handlers moved a Payment Request to processing before checking that its payment method is a PayPal one, and RefundPayPalCapturePaymentRequestHandler did not check it at all (#812 (comment), #812 (comment)).

Both handlers now check the gateway factory before the process transition and fail a request of another gateway straight from new, without calling PayPal.

@GSadee GSadee added the Bug label Oct 20, 2026
@GSadee
GSadee merged commit 23da9be into Sylius:phase-2-payment-requests Oct 20, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants