[BootstrapAdminUi] Add a body hookable to the create/update content composition#375
[BootstrapAdminUi] Add a body hookable to the create/update content composition#375vvasiloi wants to merge 1 commit into
Conversation
5b8b084 to
d11100e
Compare
d11100e to
9b6b7c3
Compare
Tabler's header-to-content spacing comes from .page-body's top margin against its .page-header sibling. The create/update pages render no .page-body, so the form card sits glued to the sticky header. BC break: form_error_alert and form move from …content.* to …content.body.*.
9b6b7c3 to
bca6861
Compare
|
CI failures are unrelated: |
|
@vvasiloi Thx for your proposal, on Sylius E-commerce how is it done? |
|
@loic425 In Sylius e-commrece it's not done at all, at least not structurally. The shared Sylius proper fixes the visual bug via CSS in plus the sticky-header script that toggles So the header-to-content gap comes from the header's own The only places Sylius emits …that opens the wrapper itself: So the two fixes are alternatives, not complements. There are two ways forward:
I lean towards the structural change beacuse it also makes more sense semantically. |
Create/update pages render no
.page-body, so the form card sits glued to the sticky page header — the header-to-content spacing in Tabler comes from.page-body's top margin against its.page-headersibling.This adds a
bodyhookable (rendering.page-body) to the create/update content composition;form_error_alertandformmove under it.BC break: hook customizations targeting
sylius_admin.common.{create,update}.content.form*must retarget…content.body.form*— documented in the newUPGRADE.md.