Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
188 changes: 188 additions & 0 deletions backend/app/tests/users/integration/test_user_routes.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,188 @@
"""Testes dos endpoints de usuário autenticado (/api/v1/user/me)."""

from __future__ import annotations

import pytest
from sqlalchemy.ext.asyncio import AsyncSession

from app.auth import services as auth_services
from app.auth.scopes import Scope
from app.auth.security import verify_password

URL = "/api/v1/user/me"


def _auth(user, scopes=(Scope.PROFILE, Scope.EMAIL)) -> dict[str, str]:
token = auth_services.create_access_token(user.id, list(scopes))
return {"Authorization": f"Bearer {token}"}


# ---------------------------------------------------------------------------
# Proteção
# ---------------------------------------------------------------------------


async def test_update_name_without_authorization_returns_401(db_client):
r = await db_client.patch(URL, json={"name": "Novo Nome"})
assert r.status_code == 401


async def test_update_name_without_profile_scope_returns_401(
db_client, regular_user, db_session: AsyncSession
):
original_name = regular_user.name

r = await db_client.patch(
URL, json={"name": "Novo Nome"}, headers=_auth(regular_user, [Scope.EMAIL])
)

assert r.status_code == 401
await db_session.refresh(regular_user)
assert regular_user.name == original_name


async def test_update_name_without_email_scope_returns_401(
db_client, regular_user, db_session: AsyncSession
):
original_name = regular_user.name

r = await db_client.patch(
URL, json={"name": "Novo Nome"}, headers=_auth(regular_user, [Scope.PROFILE])
)

assert r.status_code == 401
await db_session.refresh(regular_user)
assert regular_user.name == original_name


async def test_update_name_of_deleted_user_returns_401(db_client, deleted_user_factory):
deleted = await deleted_user_factory()

r = await db_client.patch(URL, json={"name": "Novo Nome"}, headers=_auth(deleted))

assert r.status_code == 401


# ---------------------------------------------------------------------------
# Sucesso
# ---------------------------------------------------------------------------


async def test_user_can_update_own_name(
db_client, regular_user, db_session: AsyncSession
):
r = await db_client.patch(
URL, json={"name": "Ada Lovelace"}, headers=_auth(regular_user)
)

assert r.status_code == 200, r.text
body = r.json()
assert body["name"] == "Ada Lovelace"
assert body["id"] == str(regular_user.id)
assert body["email"] == regular_user.email
assert "password" not in body and "password_hash" not in body

await db_session.refresh(regular_user)
assert regular_user.name == "Ada Lovelace"


async def test_updated_name_is_returned_by_me_endpoint(db_client, regular_user):
headers = _auth(regular_user)

await db_client.patch(URL, json={"name": "Grace Hopper"}, headers=headers)
r = await db_client.get("/api/v1/auth/me", headers=headers)

assert r.status_code == 200, r.text
assert r.json()["name"] == "Grace Hopper"


async def test_update_name_strips_surrounding_whitespace(db_client, regular_user):
r = await db_client.patch(
URL, json={"name": " Linus Torvalds "}, headers=_auth(regular_user)
)

assert r.status_code == 200, r.text
assert r.json()["name"] == "Linus Torvalds"


async def test_update_name_accepts_max_length(db_client, regular_user):
name = "a" * 255

r = await db_client.patch(URL, json={"name": name}, headers=_auth(regular_user))

assert r.status_code == 200, r.text
assert r.json()["name"] == name


async def test_update_name_does_not_change_other_fields(
db_client, regular_user, db_session: AsyncSession
):
email = regular_user.email
password_hash = regular_user.password_hash

r = await db_client.patch(
URL, json={"name": "Outro Nome"}, headers=_auth(regular_user)
)

assert r.status_code == 200, r.text
await db_session.refresh(regular_user)
assert regular_user.email == email
assert regular_user.password_hash == password_hash
assert verify_password("password123", regular_user.password_hash)
assert regular_user.is_admin is False
assert regular_user.is_verified is False


# ---------------------------------------------------------------------------
# Validação
# ---------------------------------------------------------------------------


@pytest.mark.parametrize(
"payload",
[
{},
{"name": None},
{"name": ""},
{"name": " "},
{"name": "a" * 256},
{"name": 123},
],
)
async def test_update_name_rejects_invalid_name(
db_client, regular_user, db_session: AsyncSession, payload
):
original_name = regular_user.name

r = await db_client.patch(URL, json=payload, headers=_auth(regular_user))

assert r.status_code == 422
await db_session.refresh(regular_user)
assert regular_user.name == original_name


@pytest.mark.parametrize(
"extra",
[
{"email": "hacker@example.com"},
{"password": "brand-new-pass"},
{"is_admin": True},
{"is_verified": True},
],
)
async def test_update_name_rejects_other_fields(
db_client, regular_user, db_session: AsyncSession, extra
):
email = regular_user.email
original_name = regular_user.name

r = await db_client.patch(
URL, json={"name": "Novo Nome", **extra}, headers=_auth(regular_user)
)

assert r.status_code == 422
await db_session.refresh(regular_user)
assert regular_user.email == email
assert regular_user.name == original_name
assert regular_user.is_admin is False
assert regular_user.is_verified is False
26 changes: 24 additions & 2 deletions backend/app/users/routes.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
from typing import Annotated

from fastapi import APIRouter, Depends, status
from fastapi import APIRouter, Depends, Security, status
from sqlalchemy.ext.asyncio import AsyncSession

from app.auth.dependencies import get_current_user
from app.auth.scopes import Scope
from app.core.database import get_session
from app.core.exceptions.app_errors import UnauthorizedError
from app.users import services
from app.users.schemas import UserCreate
from app.users.models import User
from app.users.schemas import UserCreate, UserMe, UserNameUpdate, UserUpdate

router = APIRouter(tags=["user"])

Expand All @@ -18,3 +22,21 @@ async def signup_with_password(
user = await services.create_user(db_session, user_info)

return user


@router.patch("/me", response_model=UserMe)
async def update_my_name(
db_session: Annotated[AsyncSession, Depends(get_session)],
current_user: Annotated[
User, Security(get_current_user, scopes=[Scope.PROFILE, Scope.EMAIL])
],
user_in: UserNameUpdate,
):
"""Altera o nome do usuário autenticado. O e-mail não pode ser alterado aqui."""
await services.update_user(db_session, current_user, UserUpdate(name=user_in.name))
await db_session.commit()

user = await services.get_user_profile_by_id(db_session, current_user.id)
if user is None:
raise UnauthorizedError(detail="Inexistent or inactive user")
return user
9 changes: 9 additions & 0 deletions backend/app/users/schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,15 @@ class UserUpdate(BaseModel):
password: Password | None = None


class UserNameUpdate(BaseModel):
# alteração do próprio nome pelo usuário autenticado: nome obrigatório e
# nenhum outro campo aceito (e-mail, senha e privilégios não podem ser
# alterados por esta via)
model_config = ConfigDict(extra="forbid")

name: Name


class AdminUserCreate(UserCreate):
# criação feita por um admin: pode definir os privilégios já na criação
is_admin: bool = False
Expand Down
9 changes: 9 additions & 0 deletions frontend/src/features/auth/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,15 @@ export async function getCurrentUser(): Promise<User> {
return mapUser(await requestApi<ApiUser>('/auth/me'))
}

export async function updateMyName(name: string): Promise<User> {
return mapUser(
await requestApi<ApiUser>('/user/me', {
method: 'PATCH',
body: JSON.stringify({ name }),
}),
)
}

export async function restoreSession(): Promise<User | null> {
try {
await refresh()
Expand Down
8 changes: 7 additions & 1 deletion frontend/src/features/auth/auth-provider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
type ReactNode,
} from 'react'

import { login, logout, register, restoreSession } from './api'
import { login, logout, register, restoreSession, updateMyName } from './api'
import type { LoginInput, RegisterInput, User } from './types'

type AuthContextValue = {
Expand All @@ -18,6 +18,7 @@ type AuthContextValue = {
login: (input: LoginInput) => Promise<User>
register: (input: RegisterInput) => Promise<User>
logout: () => Promise<void>
updateName: (name: string) => Promise<User>
}

const AuthContext = createContext<AuthContextValue | null>(null)
Expand Down Expand Up @@ -51,6 +52,11 @@ export function AuthProvider({ children }: { children: ReactNode }) {
await logout()
setUser(null)
},
async updateName(name) {
const updated = await updateMyName(name)
setUser(updated)
return updated
},
}),
[loading, user],
)
Expand Down
Loading
Loading