Supporting RealExpr multiplication in Z3BitVector solver - #148
Open
shawshank-202 wants to merge 1 commit into
Open
shawshank-202 wants to merge 1 commit into
shawshank-202 wants to merge 1 commit into
Conversation
Author
|
Hey @sohah, ran the sv-comp benchmark found couple of issues being generated due to unsupported mult(Object,Object) they have been rectified now. Kindly have a look thank youu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#109
This Pull Request adds support for multiplication between RealExpr objects in Z3BitVector
Earlier, multiplication between symbolic real expressions was not handled in
ProblemZ3BitVector,which cause runtime failures such as:
Error Z3: mult(Object, Object) failed
Changes:
Changes on SV-COMP floating point benchmarks:
Fully solved:
Partially solved / improved support:
Related to #109