RealExpr Division support in Z3BitVector - #150
Open
shawshank-202 wants to merge 2 commits into
Open
shawshank-202 wants to merge 2 commits into
shawshank-202 wants to merge 2 commits into
Conversation
Author
|
Hey @sohah, kindly have a look when you can thank youu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #109
Adding support for division earlier missing in div(Object,Object) for RealExpr in Z3BitVector.
Division between symbolic real expressions was not handled in ProblemZ3BitVector,
which lead to failures like:
Error Z3: div(Object, Object) failed
Changes:
Added RealExpr / RealExpr using ctx.mkDiv, after adding RealExpr division support,
they now progress further and fail at:
Math.sqrt, indicating the division issue has been resolved.
Support for operations such as Math.sqrt will be reflected in future updates.
Changes on SV-COMP floating point benchmarks:
Partially solved / improved support:
Optimization3
coral61
coral62
coral63
coral64
coral65
coral66
#109