Repository navigation
fix: CORS hardening and production URL config (#63-#66) - #139
Merged
victorisiguzoruzoma874 merged 4 commits intoOct 19, 2026
Merged
victorisiguzoruzoma874 merged 4 commits into
victorisiguzoruzoma874 merged 4 commits into
Conversation
|
@Dev-makeem is attempting to deploy a commit to the work Team on Vercel. A member of the Team first needs to authorize it. |
|
@Dev-makeem Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
victorisiguzoruzoma874
merged commit Oct 19, 2026
fc6d8d3
into
SynapsVault:main
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
Closes #64
Closes #65
Closes #66
Summary
64f4ff8: fix(config): require BASE_URL and WEB_APP_URL in production (#63)
Added a pre-validation check in
src/config.tsthat exits at boot with a clear[config]message whenNODE_ENV=productionand eitherBASE_URLorWEB_APP_URLis unset or blank. Development and test behavior, including the localhost defaults, is unchanged.5b1c738: fix(cors): allow PATCH in preflight (#64)
Added
PATCHto the allowed methods increateCorsOptions(src/cors.ts) so browser preflights for the PATCH publisher routes succeed. A test insrc/cors.test.tsasserts the method is present.b44702e: fix(cors): bound rejected-origin tracking (#65)
Replaced the unbounded
warnedOriginsbookkeeping with amarkOriginWarnedhelper capped atMAX_WARNED_ORIGINS(500) that evicts the oldest entry at the limit. A test insrc/cors.test.tscovers the cap.585f677: fix(ci): replace wildcard ALLOWED_ORIGINS in catalog seed workflow (#66)
Replaced
ALLOWED_ORIGINS: "*"in.github/workflows/catalog-seed.ymlwith an explicit local origin. Also setBASE_URLandWEB_APP_URLthere so the production-mode seed run still boots under the new requirement from #63.