Repository navigation
feat: add IP rate limit to POST /publishers (#38) - #144
Merged
victorisiguzoruzoma874 merged 1 commit intoOct 19, 2026
Merged
victorisiguzoruzoma874 merged 1 commit into
victorisiguzoruzoma874 merged 1 commit into
Conversation
Apply a sliding-window IP rate limiter to the publisher registration endpoint so unlimited account and API-key creation from a single IP is no longer possible. Changes: - config.ts: add RATE_LIMIT_REGISTER_IP_MAX (default 10) and RATE_LIMIT_REGISTER_IP_WINDOW_MS (default 1 hour) to envSchema - rateLimiters.ts: export registerIpRateLimit via createIpRateLimiter - publishers.ts: mount registerIpRateLimit before validate() on POST /publishers; exceeding the limit returns 429 RATE_LIMITED - publishers.register-rate-limit.test.ts: 6 new tests covering header values, 429 shape, window reset, per-IP isolation, and route wiring - publishers.test.ts: fix pre-existing failure — replace invalid Stellar address "GALICE" with a real 56-char G... key so schema passes - publishers.webhooks.test.ts: add registerIpRateLimit pass-through to the rateLimiters mock (pre-existing omission) - .env.example: document the two new env vars - README.md: add Registration row to the rate-limiting table and an explanatory paragraph
|
@euniceamoni is attempting to deploy a commit to the work Team on Vercel. A member of the Team first needs to authorize it. |
|
@euniceamoni Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
victorisiguzoruzoma874
merged commit Oct 19, 2026
cf5a7c7
into
SynapsVault:main
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply a sliding-window IP rate limiter to the publisher registration endpoint so unlimited account and API-key creation from a single IP is no longer possible.
Changes: