Repository navigation
docs(security): update SECURITY_AUDIT init front-running status and residual risk - #145
Merged
Busiii-adetiba merged 1 commit intoOct 17, 2026
Conversation
…ynapsVault#104) The init front-running fix for access-lease (SynapsVault#43, review item 11) was recorded as SV-12 "Resolved", but the admin.require_auth() check and its test were dropped when PR SynapsVault#141 was merged, and subscription and vault-registry never had it. Mark SV-12 as open/regressed across all three contracts, correct the status line and access-control matrix, and add the init front-running residual risk with operational mitigations until the check is restored. Closes SynapsVault#104 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@adenueltech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #104
Context
#104 asks to update the SECURITY_AUDIT residual risk on init front-running "once #11 is fixed". "#11" is review item 11, tracked as issue #43 (
[access-lease] init does not require admin auth…).While checking the current code I found the audit is out of sync:
c7eda2e. That commit addedadmin.require_auth()inaccess-lease::init, the testinit_requires_admin_auth, and audit row SV-12 – Resolved.eee2a5d, Oct 17).access-lease::initcurrently writes the admin without any auth, andinit_requires_admin_authno longer exists. The SV-12 row still says "Resolved".subscription::initandvault-registry::inithave never required the admin's signature.docs/CONTRACTS.mdalready says "initdoes not require the admin's signature, so deploy and init in the same pipeline run", which contradicts the audit.What changed (
SECURITY_AUDIT.md)c7eda2e, regressed ineee2a5d) along with the required fix, and the status is set to Open (regressed).initrow now says no signer is required and that the test was removed. It previously cited a test that no longer exists.initback to back, verifyadmin()immediately, and redeploy if it's wrong, since a hijacked admin can't be recovered. It notes that SV-12 can go back to Resolved once the check returns.Docs only. Restoring
admin.require_auth()in eachinit(plus tests) is a small code follow-up I'm happy to open separately. Note that CI onmainhas been failing since Oct 16 for unrelated compile errors, so CI on this PR will fail for the same reason.🤖 Generated with Claude Code