02-fund-accounts.js exits 0 when funding fails and crashes on non-JSON responses #31

Activity

1. Busiii-adetiba

   added

   bugSomething isn't workingSomething isn't working

   good first issueGood for newcomersGood for newcomers

   on Oct 14, 2026
2. drips-wave

   added

   Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave program

   on Oct 14, 2026
3. fakayodeteminijesu45-source commented on Oct 16, 2026

   

   fakayodeteminijesu45-source

   on Oct 16, 2026 – with Drips Wave

   More actions

   @fakayodeteminijesu45-source has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

   Hello Maintainer, I’ve carefully reviewed the issue and understand what needs to be done. I’m interested in working on it and will do my best to provide a reliable solution that meets the project’s requirements. I’d appreciate the opportunity to contribute. Thank you for your consideration.

   ℹ️ Repo Maintainers: To accept this application, review their application or assign @fakayodeteminijesu45-source to this issue.
4. kwest0002-lab commented on Oct 18, 2026

   

   kwest0002-lab

   on Oct 18, 2026 – with Drips Wave

   More actions

   @kwest0002-lab has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

   hi please i will love to work on this

   ℹ️ Repo Maintainers: To accept this application, review their application or assign @kwest0002-lab to this issue.
5. Yuren0312

   added a commit that references this issue on Oct 18, 2026

   fix(scripts): exit non-zero when Friendbot funding fails

   ...

   This issue will close once commit 339b08f is merged into the 'main' branch.

   339b08f
6. Yuren0312 commented on Oct 18, 2026

   

   Yuren0312

   on Oct 18, 2026

   Contributor

   More actions

   Fix submitted in #111:

   • every key is validated with StrKey.isValidEd25519PublicKey before Friendbot is contacted (invalid keys abort with exit 1, Friendbot never called)
   • the response body is read as text first and JSON is parsed from it, so Friendbot's HTML/text error bodies are reported instead of crashing the step
   • an already funded response counts as success
   • the script exits non-zero if any account could not be funded, so the step can be chained with &&
   • the exit-code contract is covered by test/fund-accounts.test.cjs, which spawns the script with fetch stubbed (no network calls)

   Happy to adjust the wording or behaviour if you'd prefer something different.
7. Busiii-adetiba

   closed this as completedin #111on Oct 18, 2026