Repository navigation
Fix DB alerts, add runbooks, and configure real Alertmanager receivers - #124
Merged
Merged
Conversation
|
@Teeeyanaa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix DB alerts, add runbooks, and configure real Alertmanager receivers
What was solved
#88 — DatabaseDown alert measures the exporter, not Postgres
Update monitoring/alert-rules.yml so the DatabaseDown alert fires on pg_up == 0 (actual Postgres availability) instead of only up{job="database"} == 0 (exporter availability), and add/keep a separate alert for the postgres-exporter being down.
Addressed:
#89 — Replace placeholder runbook URLs with real runbooks
Replace placeholder docs.example.com runbook URLs in monitoring/alert-rules.yml with real runbook files authored under docs/runbooks/, one per alert, and update the alert rules to point runbook_url at those docs.
Addressed:
#90 — Configure real Alertmanager receivers
Replace the dead localhost webhook receiver in monitoring/alertmanager.yml with real Slack, PagerDuty, and email receivers sourced from env/secret files, and add routing so critical alerts go to high-urgency channels (PagerDuty + Slack critical + email) while warnings go to lower-urgency channels (Slack warnings + email).
Addressed:
Changes
monitoring/alert-rules.yml(modify)docs/MONITORING.md(modify)monitoring/alertmanager.yml(modify).env.example(modify)Approach
Issues
Closes #88
Closes #89
Closes #90