Repository navigation
Use dedicated ServiceAccounts without auto-mounted API tokens - #127
Merged
Merged
Conversation
…nt disabled Closes SynapsVault#60
…ng/production Closes SynapsVault#61
…r document cre Closes SynapsVault#63
|
@kyarijummai Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use dedicated ServiceAccounts without auto-mounted API tokens
What was solved
#60 — Use a dedicated ServiceAccount with token automount disabled
Add dedicated ServiceAccounts for the backend and frontend with automountServiceAccountToken disabled, and wire the existing deployments to use them so pods no longer rely on the default ServiceAccount with an auto-mounted API token.
Addressed:
#61 — Restructure k8s/ into a Kustomize base with staging/production overlays
Restructure the flat k8s/ manifests into a Kustomize base plus staging and production overlays, moving environment-specific values (host, network/RPC, replicas, resources) into per-overlay patches, and update the deploy-k8s CI workflow and Kubernetes deployment docs to validate/render the new layout.
Addressed:
#62 — Parameterise the ingress host instead of
app.example.comParameterise the Kubernetes ingress host, TLS secret, and ALLOWED_ORIGINS so they are no longer hardcoded to app.example.com placeholders. Use Kustomize overlay patches / a deploy-time variable (vars.DEPLOY_HOST) so the host is set at deploy time rather than hand-edited in k8s/ingress.yaml and k8s/configmap.yaml.
Addressed:
#63 — Include the cert-manager ClusterIssuer manifest or document creating it
Add an example cert-manager ClusterIssuer manifest (HTTP-01 via nginx) for the
letsencrypt-prodissuer referenced byk8s/ingress.yaml, and document the cert-manager prerequisites indocs/DEPLOY-KUBERNETES.md.Addressed:
letsencrypt-prodto match the ingress annotationChanges
k8s/frontend-deployment.yaml(modify)k8s/backend-deployment.yaml(modify)k8s/kustomization.yaml(modify).github/workflows/deploy-k8s.yml(modify)k8s/ingress.yaml(modify)docs/DEPLOY-KUBERNETES.md(modify)k8s/configmap.yaml(modify)Approach
app.example.com#62 — Parameterise the ingress host instead ofapp.example.com(Changed: k8s/ingress.yaml, k8s/configmap.yaml, k8s/kustomization.yaml)Issues
Closes #60
Closes #61
Closes #62
Closes #63