Repository navigation
Build/deploy hardening: slim migrate stage, runtime frontend config, env var reconciliation - #128
Merged
Busiii-adetiba merged 5 commits intoOct 19, 2026
Conversation
|
@Kinghezzy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build/deploy hardening: slim migrate stage, runtime frontend config, env var reconciliation
What was solved
#100 — Slim down the backend migrate image
Slim the backend
migrateDocker target so the init/migration image contains only what drizzle-kit needs (drizzle-kit, config, and migrations) instead of the full build stage with dev deps, sources, and compilers.Addressed:
#101 — Support runtime configuration for the frontend image
Add runtime frontend configuration so a single frontend image can serve staging and production: generate /config.js at container start from environment variables in frontend/Dockerfile, and update the k8s deploy workflow to pass runtime env vars instead of relying on build-time VITE_* values.
Addressed:
#102 — Track removal of
--legacy-peer-depsfrom the DockerfilesDocument the temporary
--legacy-peer-depsworkaround in both Dockerfiles by adding tracking comments that reference the upstream peer-dependency conflicts (x402-stellar vs stellar-sdk in the backend, missing frontend lockfile) and note the condition for dropping the flag. This satisfies the tracking/linking intent without changing build behavior, since the flag cannot be removed until upstream issues are resolved.Addressed:
#103 — Environment variable names are inconsistent between .env.example, ConfigMap and Secret
Reconcile environment variable names across .env.example, k8s/configmap.yaml, k8s/secrets.yaml, and docs/ENVIRONMENT-VARIABLES.md so they match what the backend actually reads. Fix mismatches like STELLAR_SOROBAN_RPC_URL vs SOROBAN_RPC_URL, SUPABASE_SERVICE_ROLE_KEY vs SUPABASE_SERVICE_KEY, single STELLAR_CONTRACT_ID vs three contract IDs, and add missing AGENT_SECRET_KEY, REGISTRY_SECRET_KEY, OPENROUTER_API_KEY, and USDC_CONTRACT_ID entries.
Addressed:
Changes
backend/Dockerfile(modify).github/workflows/deploy-k8s.yml(modify)k8s/frontend-deployment.yaml(modify).env.example(modify)k8s/secrets.yaml(modify)frontend/Dockerfile(modify)k8s/configmap.yaml(modify)docs/ENVIRONMENT-VARIABLES.md(modify)Approach
--legacy-peer-depsfrom the Dockerfiles #102 — Track removal of--legacy-peer-depsfrom the Dockerfiles (Changed: backend/Dockerfile, frontend/Dockerfile)Issues
Closes #100
Closes #101
Closes #102
Closes #103