Skip to content

Document required metrics and alert on missing instrumentation - #130

Merged
Busiii-adetiba merged 2 commits into
SynapsVault:mainfrom
Teeeyanaa:drips/91
Oct 19, 2026
Merged

Busiii-adetiba merged 2 commits into
SynapsVault:mainfrom
Teeeyanaa:drips/91

Conversation

@Teeeyanaa

Copy link
Copy Markdown
Contributor

Summary

Document required metrics and alert on missing instrumentation

What was solved

#91 — Verify the backend actually exposes the metrics alert rules depend on

Document the metrics that monitoring alert rules depend on (db_connection_pool_, stellar_rpc_, soroban_rpc_*) in docs/MONITORING.md, and add absent() checks in monitoring/alert-rules.yml so missing instrumentation surfaces as an alert instead of silently never firing. The acceptance criterion about opening issues in SynapsVault/backend is an external action outside this repo's code changes and will be noted as a follow-up rather than performed here.

Addressed:

  • Changed: monitoring/alert-rules.yml, docs/MONITORING.md
  • List the required metrics (db_connection_pool_, stellar_rpc_, soroban_rpc_*) in docs/MONITORING.md
  • Add absent() checks in monitoring/alert-rules.yml where useful so missing metrics are detected
  • Keep changes scoped to monitoring/alert-rules.yml and docs/MONITORING.md

Changes

  • monitoring/alert-rules.yml (modify)
  • docs/MONITORING.md (modify)

Approach

  1. Read monitoring/alert-rules.yml and docs/MONITORING.md to understand existing alert groups, metric naming, and doc structure.
  2. In docs/MONITORING.md, add a section listing the required metrics (db_connection_pool_, stellar_rpc_, soroban_rpc_*) that alert rules depend on, with brief descriptions.
  3. In monitoring/alert-rules.yml, add absent() based alert rules (with appropriate for: durations) for the key metrics so missing instrumentation triggers an alert.
  4. Note in the docs that opening matching issues in SynapsVault/backend is an external follow-up.
  5. Verify metric names in new absent() rules match those documented and used by existing rules.

Issues

Closes #91

@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Teeeyanaa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Busiii-adetiba
Busiii-adetiba merged commit 47539fd into SynapsVault:main Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify the backend actually exposes the metrics alert rules depend on

2 participants