Repository navigation
Document required metrics and alert on missing instrumentation - #130
Merged
Merged
Conversation
|
@Teeeyanaa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document required metrics and alert on missing instrumentation
What was solved
#91 — Verify the backend actually exposes the metrics alert rules depend on
Document the metrics that monitoring alert rules depend on (db_connection_pool_, stellar_rpc_, soroban_rpc_*) in docs/MONITORING.md, and add absent() checks in monitoring/alert-rules.yml so missing instrumentation surfaces as an alert instead of silently never firing. The acceptance criterion about opening issues in SynapsVault/backend is an external action outside this repo's code changes and will be noted as a follow-up rather than performed here.
Addressed:
Changes
monitoring/alert-rules.yml(modify)docs/MONITORING.md(modify)Approach
Issues
Closes #91