Repository navigation
Harden ingress, track contract IDs, and document External Secrets setup - #131
Merged
Merged
Conversation
|
@Zizee1994 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden ingress, track contract IDs, and document External Secrets setup
What was solved
#64 — Add security headers and rate limiting to the API ingress
Add NGINX ingress rate limiting annotations (limit-rps, limit-connections) and enable HSTS via security headers on the API ingress in k8s/ingress.yaml, scoped strictly to the edge ingress configuration.
Addressed:
#65 — Add contract ID keys to the backend ConfigMap
Add placeholder contract ID keys to the backend ConfigMap so the keys patched by rollback-contracts.cjs are tracked in Git, and document the post-deploy update flow for keeping the ConfigMap in sync with deployed contract IDs.
Addressed:
#66 — Provide an ExternalSecret example for backend-secret
Add a standalone ExternalSecret example manifest for the backend-secret and document how to set it up with the External Secrets Operator, without wiring it into kustomization.
Addressed:
Changes
k8s/configmap.yaml(modify)docs/contract-deploy-guide.md(modify)docs/DEPLOY-KUBERNETES.md(modify)k8s/ingress.yaml(modify)scripts/rollback-contracts.cjs(modify)k8s/examples/external-secret.yaml(create)Approach
Issues
Closes #64
Closes #65
Closes #66