Repository navigation
fix(adapters): parse wolfxl plain-string fill colors - #46
Merged
Merged
Conversation
WolfXL exposes PatternFill fgColor as a plain ARGB string where openpyxl returns a Color object, so _color_to_hex returned None for every wolfxl conditional-format rule and the fidelity read lane dropped all format expectations (wolfxl scored 0/3 on conditional_formatting in the 2026-09-08 snapshot). Accept the plain-string spelling alongside Color objects. Verification: wolfxl conditional_formatting now 3/3 read and write against the fixed wolfxl tree; full suite green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Triage follow-up to the 2026-09-08 competitor snapshot (PR #45). WolfXL exposes
PatternFill.fgColoras a plain ARGB string where openpyxl returns aColorobject, so_color_to_hexreturnedNonefor every wolfxl conditional-format rule and the read lane dropped allformatexpectations._color_to_hexnow accepts the plain-string spelling alongsideColorobjects.format: {"bg_color": "#FFFF00"}.Paired with SynthGL/wolfxl
fix/write-mode-local-sheet-id(print-title and named-range scope corruption), wolfxl now scores 3/3 read and write onconditional_formatting,named_ranges, andpage_setup, and 21/21 features overall on the fidelity lane.Verification
uv run --no-sync ruff check .cleanuv run --no-sync mypyclean (151 files)excelbench benchmark -t fixtures/excel -a wolfxl: 21/21 features 3/3 (pivot_tables N/A)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.