Repository navigation
fix: end --header flags with -- in the printed claude mcp add command (PROJ-978) - #394
Merged
Merged
Conversation
… (PROJ-978) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014JyYB2AfPyH695ScaeCofW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-H, --header <header...>is variadic on current Claude Code, so--header … projektor "<url>"made it swallow the name and URL (error: missing required argument 'name', shell exit still 0). Both builders inpackages/types/src/mcp-command.tsnow emit… --header "…" -- projektor "<url>". That covers the/bootstrapmcpAddCommand,mcp-info'smcpAddCommandTemplate, and the token dialog. Pinned tests (workspaces.test.ts, TokenManager.test.tsx) updated;mcp-connection.mdno longer says the printed command is broken.Fixes PROJ-978.
Verified
wrangler dev: ran the/bootstrap-printed command (with--scope localand a scratch namescratch978in a temp dir), thenclaude mcp list→✔ Connected. Entry removed afterwards (claude mcp remove scratch978 -s local, confirmed gone); the user-scope config was never modified.claude mcp addfails, hence the explicit list check.workspaces.test.ts(45) and webTokenManager.test.tsx(8) pass; biome clean.Assumed
--also works on older Claude Code is taken from the ticket ("works whichever order an older CLI expects"); I only tested 2.1.289.🤖 Generated with Claude Code
https://claude.ai/code/session_014JyYB2AfPyH695ScaeCofW