fix: resolve environment metadata on profile create with explicit --name - #184
Open
zekelinAlex wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config profile create --url ... --name ...saved the connection without environmentType, displayName, organizationId and environmentId. The catalog lookup only ran when we needed to derive a profile name, so passing --name (or re-creating a profile for an already known connection) skipped it entirely. Worse, since the upsert replaces the whole connection, re-running create actually wiped metadata thatprofile validate --refresh-env-typehad persisted earlier.The practical fallout: a connection without environmentType is treated as production by the destructive-operation guard, so deletes on a plain devbox started demanding --allow-production. Agents then just pass the flag automatically, which defeats the point of the guard.
The lookup now runs on every create path (still best-effort, failure logs a warning and falls back), and when it fails we carry over whatever metadata the existing connection already had instead of overwriting it with nulls. Two new tests cover the explicit-name case and the don't-wipe-on-failed-lookup case.