Repository navigation
trellis API - #330
trellis API#330
Conversation
Code Review & Auto-Merge — @dorismaduegbunam 🚀Thank you @Ghoost-404 for your contribution!
Verified code changes and repository requirements. Merging pull request. |
|
This October PR is currently conflicting/dirty against the base branch and was not merged. Please update the branch, resolve conflicts, rerun CI, and request a fresh review. |
1 similar comment
|
This October PR is currently conflicting/dirty against the base branch and was not merged. Please update the branch, resolve conflicts, rerun CI, and request a fresh review. |
|
@Ghoost-404 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Code Review & Auto-Merge — @dorismaduegbunam 🚀Thank you @Ghoost-404 for your contribution!
Verified code changes and repository requirements. Merging pull request. |
Closes #298
Closes #299
Closes #300
Closes #301
Summary of Completed Work
1. Accessibility Coverage for Keyboard, Focus, and Async Status States
Tab,Shift+Tab,Space,Enter,Escape) in accessibility.types.ts.idle,submitting,retrying,unauthorized,failed,timeout,aborted, andsucceeded.asyncStatussuites across all 5 core domains (auth,portfolio,defi,notifications,observability) in accessibility.suites.ts.idletosubmittingtosucceededwith polite announcements and focus movement to completion targets.Escape, polite cancellation announcements, and focus recovery.npx jest src/common/accessibility/accessibility.spec.ts: 86 passed, 86 total.npm run verify:accessibility: 27 invariants passed, 0 failed.2. Contributor Diagnostics for Environment and Dependency Validation
unreachable), incorrect credentials (auth_failed), and missing databases (db_missing)..env, weak/placeholder secrets, database missing, unauthorized credentials with actionable remediation.npx jest src/diagnostics/diagnostics-checks.spec.ts: 41 passed, 41 total.npm run diagnostics -- --quick: Verified CLI report generation and exit codes.3. Explainable Risk Scoring for Suspicious High-Impact Actions
getErrorTaxonomyandsanitizeClientMessage).lastEvaluatedAtMs) so review queries respect evaluation contexts rather than prematurely expiring against wall-clock time.allow_after_step_up.npx jest src/security/abuse-detection/abuse-detection.spec.ts: 13 passed, 13 total.npm run verify:abuse-detection: 8 invariants passed, 0 failed.4. Release Readiness Checks for Migrations, Smoke Tests, and Rollback
down()methods, explicitLOCK TABLEorACCESS EXCLUSIVE, non-concurrent indexes (CREATE INDEXwithoutCONCURRENTLY), andNOT NULLcolumn additions without defaults.@UseGuards(JwtAuthGuard, RolesGuard)and@Roles(Role.ADMIN)."verify:release-readiness"in package.json.down(), table-level locks, non-concurrent index creation, probe failures, breaking column additions, blocked release sign-offs.npx jest src/common/release/release-readiness.spec.ts: 23 passed, 23 total.npm run verify:release-readiness: 8 invariants passed, 0 failed.