Report test results in the CI run summary too - #47
Merged
Merged
Conversation
The coverage job ran the tests and reported only coverage, so the test
results stayed in the job log. Node prints its own summary block right
before the coverage report, so surfacing it costs one more `grep`.
Reporting now happens in its own step. The default shell is `bash -e`, so
`set -o pipefail` made a failing suite abort the step before it wrote the
summary — the run lost both the results and the coverage report at the
one moment they were most worth reading. Node emits both even when tests
fail, so `if: ${{ !cancelled() }}` is enough to keep them.
This matches the shape of the job in queryql:
TRUEPIC/queryql#96
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #46, aligning it with the equivalent job in queryql:
TRUEPIC/queryql#96
Two changes.
The job already ran the whole suite but reported only coverage, so the test
results stayed in the job log. Node prints its own summary block immediately
before the coverage report, so surfacing it costs one more
grepover outputwe were already capturing.
More importantly, reporting now happens in its own step. The default shell is
bash -e, so theset -o pipefailadded in #46 made a failing suite abort thestep before the summary block ran — meaning a red run got no summary at all,
losing both the results and the coverage report at the one moment they were
most worth reading. I checked with a deliberately failing test:
bash -ewitha failing pipe exits 1 and never reaches the following block. Node emits both
its summary and the coverage report even when tests fail, so splitting the
report into its own step with
if: ${{ !cancelled() }}is enough to keep them.$RUNNER_TEMP/coverage.txtis renamed totests.txt, since it now holds both.AGENTS.mdgets the same one-line correction.Rendered summary:
🤖 Generated with Claude Code