Skip to content

Tidy up colour mode handling (#1085) - #1086

Merged
SirSparkles merged 1 commit into
TV-Rename:masterfrom
kadeschs:themes-tidy
Nov 17, 2026
Merged

SirSparkles merged 1 commit into
TV-Rename:masterfrom
kadeschs:themes-tidy

Conversation

@kadeschs

Copy link
Copy Markdown
Collaborator

Closes #1085.

  • UI.ApplyColorOverrides removed. UpdateColorControls already handles tab pages and buttons for each theme. In Light it was also turning the main window's tab pages grey and putting the Update Available button on the standard look so those two are now set in UI.Designer.cs and nothing changes on screen.
  • TVSettings.ColorMode and ColorModeActual removed. The colour mode now comes from the theme as ThemeManager.SystemColorMode (Dark for a dark based theme, otherwise Classic) and IsDark is built on it. I put it in ThemeManager next to ActiveTheme rather than on TVSettings, since that is where the current theme lives.
  • Application.SetColorMode is called once in OnCreateMainForm after ThemeManager.Load(). The calls in Program.Main and the OnInitialize override ran before the settings were loaded so they always set Classic which is already the default.
  • Everything else already used ThemeManager.IsDark. The one check that can't is the start-up one in OnCreateMainForm. IsDark also needs Application.IsDarkModeEnabled which only turns on with the SetColorMode call right below it so that check reads ThemeManager.SystemColorMode.

The btnUpdateAvailable has BackColor = ActiveCaption in the designer but it looks like the old override has been putting it on the standard look. I left it with today's look. You can set UseVisualStyleBackColor to false if you prefer.

@SirSparkles
SirSparkles merged commit 792f5e5 into TV-Rename:master Nov 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Confusing Color mode implemetation

2 participants