Repository navigation
New themes - #677
Merged
Merged
New themes#677
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (66)
💤 Files with no reviewable changes (52)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe change adds Material and Material Mono themes, configurable appearance settings, display-shape and inset support, reusable widgets, and grid navigation. Applications adopt themed widgets and revised layouts. Input handling adds focus-navigation keys and trackball key mode. Status-bar behavior changes, several ESP-IDF LVGL wrappers are removed, and the LVGL dependency changes from 9.3.0 to 9.4.0. Priority: ➖ Normal Merge Risk: 🟡 Moderate · up to Existing favourites will not appear after an upgrade, and selecting an unchanged theme can prompt an unnecessary Apply action. Custom input-group navigation may also break. Address these issues before merging. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 15.72% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 229 functions across 82 files. (12 skipped: 12 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
d30b0ae4-aade-44bb-bfc9-b2c79824ae4b
📒 Files selected for processing (18)
Modules/lvgl-module/include/lvgl/theme.hModules/lvgl-module/include/lvgl/widgets/chip.hModules/lvgl-module/private/lvgl/theme_private.hModules/lvgl-module/source/devices/devices.cppModules/lvgl-module/source/devices/display.cppModules/lvgl-module/source/symbols.cModules/lvgl-module/source/theme.cppModules/lvgl-module/source/themes/lv_theme_material.cModules/lvgl-module/source/themes/lv_theme_material_mono.cModules/lvgl-module/source/widgets/chip.cppModules/lvgl-module/themes/material.lssModules/lvgl-module/themes/material_mono.lssTactility/Include/Tactility/settings/AppearanceSettings.hTactility/Private/Tactility/lvgl/Theme.hTactility/Source/app/appearancesettings/AppearanceSettings.cppTactility/Source/app/boot/BootInit.cppTactility/Source/lvgl/Theme.cppTactility/Source/settings/AppearanceSettings.cpp
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
🟡 Minor · Remove each theme’s resolution callback before freeing it. · theme.cpp:97-110
Modules/lvgl-module/source/theme.cpp:97-110
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick winRemove each theme’s resolution callback before freeing it.
When a new display selects the other theme,
lvgl_theme_init_for_display()deinitializes the current theme. The generated callback remains registered on its displays with the freed theme as user data. LVGL 9.4 emitsLV_EVENT_RESOLUTION_CHANGEDwhen rotation changes, so rotating one of those displays calls the stale callback, which passes&theme->configto the old initializer. That can read freed configuration. Remove the old callback from every display before freeingtheme_def.
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
261b101b-2f79-4827-90c9-f00dcc449e10
📒 Files selected for processing (31)
Buildscripts/sdkconfig-default.propertiesDevices/lilygo-t5-epd47-s3/device.propertiesDevices/lilygo-tdeck-max/device.propertiesDevices/lilygo-tdeck-pro/device.propertiesDevices/m5stack-papers3/device.propertiesDrivers/button-control-module/source/button_control.cppDrivers/gpio-encoder-module/bindings/tactility,gpio-encoder.yamlDrivers/gpio-encoder-module/source/gpio_encoder.cppModules/lvgl-module/CMakeLists.txtModules/lvgl-module/include/lvgl/grid_navigation.hModules/lvgl-module/include/lvgl/theme.hModules/lvgl-module/include/lvgl/widgets/badge.hModules/lvgl-module/source/devices/keyboard.cppModules/lvgl-module/source/grid_navigation.cppModules/lvgl-module/source/symbols.cModules/lvgl-module/source/theme.cppModules/lvgl-module/source/themes/lv_theme_material.cModules/lvgl-module/source/themes/lv_theme_material_mono.cModules/lvgl-module/source/widgets/badge.cppModules/lvgl-module/source/widgets/toolbar.cppModules/lvgl-module/themes/material.lssModules/lvgl-module/themes/material_mono.lssTactility/Include/Tactility/app/selectiondialog/SelectionDialog.hTactility/Source/app/AppGrid.cppTactility/Source/app/appearancesettings/AppearanceSettings.cppTactility/Source/app/launcher/Launcher.cppTactility/Source/app/selectiondialog/SelectionDialog.cppTactility/Source/settings/AppearanceSettings.cppTactilityKernel/include/tactility/drivers/keyboard.hdevice.pylv_conf.h
💤 Files with no reviewable changes (4)
- Devices/lilygo-t5-epd47-s3/device.properties
- Devices/m5stack-papers3/device.properties
- Devices/lilygo-tdeck-max/device.properties
- Devices/lilygo-tdeck-pro/device.properties
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
a2ebd1ae-91a5-4f0b-bdeb-6292b8f15103
📒 Files selected for processing (62)
Buildscripts/TactilitySDK/TactilitySDK.esp32.cmakeDevices/waveshare-s3-touch-lcd-128/waveshare,s3-touch-lcd-128.dtsDevices/waveshare-s3-touch-lcd-147/waveshare,s3-touch-lcd-147.dtsDrivers/gc9a01-module/bindings/galaxycore,gc9a01.yamlDrivers/gc9a01-module/include/drivers/gc9a01.hDrivers/gc9a01-module/source/gc9a01.cppDrivers/jd9853-module/bindings/jadard,jd9853.yamlDrivers/jd9853-module/include/drivers/jd9853.hDrivers/jd9853-module/source/jd9853.cppLICENSE.mdModules/app-module/include/app/manifest.hModules/lvgl-module/generate-icons.pyModules/lvgl-module/include/lvgl/devices/trackball.hModules/lvgl-module/include/lvgl/grid_navigation.hModules/lvgl-module/include/lvgl/icons/names.hModules/lvgl-module/include/lvgl/icons/statusbar.hModules/lvgl-module/include/lvgl/insets.hModules/lvgl-module/private/lvgl/devices/keyboard_private.hModules/lvgl-module/private/lvgl/insets_math.hModules/lvgl-module/source/devices/keyboard.cppModules/lvgl-module/source/devices/trackball.cppModules/lvgl-module/source/grid_navigation.cppModules/lvgl-module/source/icon_names.cModules/lvgl-module/source/insets.cppModules/lvgl-module/source/insets_math.cppModules/lvgl-module/source/symbols.cModules/lvgl-module/source/themes/lv_theme_material.cModules/lvgl-module/source/themes/lv_theme_material_mono.cModules/lvgl-module/source/widgets/toolbar.cppModules/lvgl-module/tests/CMakeLists.txtModules/lvgl-module/tests/source/insets_math_test.cppModules/lvgl-module/tests/source/main.cppModules/lvgl-module/themes/material.lssModules/lvgl-module/themes/material_mono.lssTactility/Include/Tactility/lvgl/Statusbar.hTactility/Private/Tactility/app/AppGrid.hTactility/Private/Tactility/app/launcher/Favourites.hTactility/Source/InitApps.cppTactility/Source/app/AppGrid.cppTactility/Source/app/appearancesettings/AppearanceSettings.cppTactility/Source/app/applist/AppList.cppTactility/Source/app/apppackagelist/AppPackageList.cppTactility/Source/app/audiosettings/AudioSettings.cppTactility/Source/app/files/State.cppTactility/Source/app/launcher/Launcher.cppTactility/Source/app/settings/Settings.cppTactility/Source/app/systeminfo/SystemInfo.cppTactility/Source/app/terminal/main.cppTactility/Source/app/trackball/TrackballSettings.cppTactility/Source/lvgl/Lvgl.cppTactility/Source/lvgl/Statusbar.cppTactility/Source/service/memorychecker/MemoryCheckerService.cppTactility/Source/service/statusbar/Statusbar.cppTactility/Source/service/webserver/WebServerService.cppTactility/Source/settings/TrackballSettings.cppTactilityKernel/bindings/display.yamlTactilityKernel/include/tactility/drivers/display.hTactilityKernel/include/tactility/paths.hTactilityKernel/source/drivers/display.cppTactilityKernel/source/paths.cppTactilityKernel/source/symbols.cTests/CMakeLists.txt
💤 Files with no reviewable changes (2)
- Tactility/Source/app/applist/AppList.cpp
- Tactility/Source/InitApps.cpp
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.