Skip to content

Theming and app updates - #678

Merged
KenVanHoeylandt merged 1 commit into
mainfrom
theming-and-app-updates
Oct 8, 2026
Merged

KenVanHoeylandt merged 1 commit into
mainfrom
theming-and-app-updates

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor
  • Refactored many apps' UI/UX
  • Improve material themes
  • Fix for Tab5 flickering on v1
  • Extend dts parser for i2c address/reg support in code
  • Fix for I2C Scanner glitch where it would show devices that aren't connected
  • Add name labels to I2C Scanner's scanned devices

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

📝 Walkthrough

Walkthrough

The pull request updates device-tree address generation, adds launcher modes, and changes LVGL theme and appearance settings. It also revises navigation and many application screens, including display, connectivity, and device settings. Other changes add shared icons, export a C++ allocation symbol, and adjust a device display clock value.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 7a584

The settings replacement retains an existing package-compatibility gap, but no new failure requiring a merge hold was established. Normal checks remain appropriate.

🚥 Pre-merge checks | ✅ 4 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ❓ Inconclusive Docstring coverage is 19.23% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 234 functions across 50 files. (11 skippe… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately identifies the pull request's major theming and application UI updates. It is broad and omits several secondary changes, but it remains related and meaningful.
Full details: Docstring Coverage

Explanation

Docstring coverage is 19.23% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 234 functions across 50 files. (11 skipped: 4 unsupported, 7 over the file limit.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3dd38c87-6485-444f-be43-d8782ceeef3a
📥 Commits

Reviewing files that changed from the base of the PR and between 0f12fcc and 7a5841b.

📒 Files selected for processing (64)
  • Buildscripts/DevicetreeCompiler/source/generator.py
  • Buildscripts/DevicetreeCompiler/tests/test_integration.py
  • Devices/m5stack-tab5/Source/devices/devices_v1.cpp
  • Documentation/ideas.md
  • Modules/cpp-symbols-module/README.md
  • Modules/cpp-symbols-module/source/module.cpp
  • Modules/lvgl-module/generate-icons.py
  • Modules/lvgl-module/include/lvgl/icons/names.h
  • Modules/lvgl-module/include/lvgl/icons/shared.h
  • Modules/lvgl-module/include/lvgl/lvgl.h
  • Modules/lvgl-module/include/lvgl/theme.h
  • Modules/lvgl-module/source/grid_navigation.cpp
  • Modules/lvgl-module/source/icon_names.c
  • Modules/lvgl-module/source/lvgl.c
  • Modules/lvgl-module/source/symbols.c
  • Modules/lvgl-module/source/theme.cpp
  • Modules/lvgl-module/source/themes/lv_theme_material.c
  • Modules/lvgl-module/source/themes/lv_theme_material.h
  • Modules/lvgl-module/source/themes/lv_theme_material_mono.c
  • Modules/lvgl-module/source/widgets/sliderbox.cpp
  • Modules/lvgl-module/source/widgets/toolbar.cpp
  • Modules/lvgl-module/themes/material.lss
  • Modules/lvgl-module/themes/material_mono.lss
  • Tactility/Include/Tactility/settings/AppearanceSettings.h
  • Tactility/Private/Tactility/app/AppGrid.h
  • Tactility/Private/Tactility/app/btmanage/View.h
  • Tactility/Private/Tactility/app/i2cscanner/I2cHelpers.h
  • Tactility/Private/Tactility/app/launcher/LauncherMode.h
  • Tactility/Private/Tactility/app/wifimanage/View.h
  • Tactility/Source/InitApps.cpp
  • Tactility/Source/app/AppGrid.cpp
  • Tactility/Source/app/appearancesettings/AppearanceSettings.cpp
  • Tactility/Source/app/apphub/AppHubApp.cpp
  • Tactility/Source/app/apphubdetails/AppHubDetailsApp.cpp
  • Tactility/Source/app/apppackagelist/AppPackageList.cpp
  • Tactility/Source/app/apwebserver/ApWebServer.cpp
  • Tactility/Source/app/audiosettings/AudioSettings.cpp
  • Tactility/Source/app/btmanage/View.cpp
  • Tactility/Source/app/btpeersettings/BtPeerSettings.cpp
  • Tactility/Source/app/chat/ChatView.cpp
  • Tactility/Source/app/development/Development.cpp
  • Tactility/Source/app/display/Display.cpp
  • Tactility/Source/app/grovesettings/GroveSettings.cpp
  • Tactility/Source/app/i2cscanner/I2cHelpers.cpp
  • Tactility/Source/app/i2cscanner/I2cScanner.cpp
  • Tactility/Source/app/keyboard/KeyboardSettings.cpp
  • Tactility/Source/app/launcher/AppsMode.cpp
  • Tactility/Source/app/launcher/Launcher.cpp
  • Tactility/Source/app/launcher/SettingsMode.cpp
  • Tactility/Source/app/ledstripsettings/LedStripSettings.cpp
  • Tactility/Source/app/localesettings/LocaleSettings.cpp
  • Tactility/Source/app/power/Power.cpp
  • Tactility/Source/app/screenshot/Screenshot.cpp
  • Tactility/Source/app/settings/Settings.cpp
  • Tactility/Source/app/systeminfo/SystemInfo.cpp
  • Tactility/Source/app/timedatesettings/TimeDateSettings.cpp
  • Tactility/Source/app/trackball/TrackballSettings.cpp
  • Tactility/Source/app/webserversettings/WebServerSettings.cpp
  • Tactility/Source/app/wifiapsettings/WifiApSettings.cpp
  • Tactility/Source/app/wificonnect/WifiConnect.cpp
  • Tactility/Source/app/wifimanage/View.cpp
  • Tactility/Source/lvgl/Statusbar.cpp
  • Tactility/Source/lvgl/Theme.cpp
  • Tactility/Source/settings/AppearanceSettings.cpp
💤 Files with no reviewable changes (3)
  • Modules/lvgl-module/source/widgets/sliderbox.cpp
  • Tactility/Source/app/settings/Settings.cpp
  • Tactility/Source/InitApps.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread Tactility/Source/app/launcher/SettingsMode.cpp
@KenVanHoeylandt
KenVanHoeylandt merged commit 24ef790 into main Oct 8, 2026
68 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the theming-and-app-updates branch October 8, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant