Crash diagnostics app rewrite

[KenVanHoeylandt]

• Crash diagnostics app doesn't use LVGL anymore. It now uses a display Device* directly.
• When there's no callstack, show a message instead
• To continue after a crash, you can use a touch/keyboard/encoder device (from touch only)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: ddd70584-f49d-433c-8359-c683b37436ba

📥 Commits

Reviewing files that changed from the base of the PR and between ad96725 and 52b133e.

📒 Files selected for processing (1)

• Tactility/Source/app/crashdiagnostics/CrashDiagnostics.cpp

🚧 Files skipped from review as they are similar to previous changes (1)

• Tactility/Source/app/crashdiagnostics/CrashDiagnostics.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

---

📝 Walkthrough

Walkthrough

Crash diagnostics now displays crash details through BootScreen after an ESP panic reset. BootScreen adds callback-based image drawing and QR-code rendering. The crash diagnostics app registration and launcher start function are removed. The ideas list also removes several entries.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 52b13

The crash screen retains a text fallback if QR allocation fails, and encoder input can continue through the keyboard path. No identified issue blocks merging.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 5 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main change: the crash diagnostics app was rewritten to use boot-screen QR display and direct crash-screen handling.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5f7fc155-1b2f-4b12-af0e-f7460c5462d6

📥 Commits

Reviewing files that changed from the base of the PR and between 24ef790 and ad96725.

📒 Files selected for processing (9)

• Documentation/ideas.md
• Tactility/Private/Tactility/app/boot/BootScreen.h
• Tactility/Private/Tactility/app/crashdiagnostics/CrashDiagnostics.h
• Tactility/Private/Tactility/app/launcher/Launcher.h
• Tactility/Source/InitApps.cpp
• Tactility/Source/app/boot/BootInit.cpp
• Tactility/Source/app/boot/BootScreen.cpp
• Tactility/Source/app/crashdiagnostics/CrashDiagnostics.cpp
• Tactility/Source/app/launcher/Launcher.cpp

💤 Files with no reviewable changes (4)

• Tactility/Source/InitApps.cpp
• Tactility/Source/app/launcher/Launcher.cpp
• Tactility/Private/Tactility/app/launcher/Launcher.h
• Documentation/ideas.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.