Skip to content

Files app refactored - #681

Merged
KenVanHoeylandt merged 1 commit into
mainfrom
files-app-refactored
Oct 9, 2026
Merged

KenVanHoeylandt merged 1 commit into
mainfrom
files-app-refactored

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor
  • New UX for Files app
  • AppGrid refactored into TileGrid

Summary by CodeRabbit

  • New Features
    • Added file-management icons for creating folders, editing, linking, copying, cutting, pasting, playing, and ejecting.
    • The file browser now displays entries in a paginated tile grid with context actions, including file operations and USB eject options.
    • App and settings tiles retain their selection when the grid refreshes, and checked icon buttons now have a distinct appearance.

+ re-use app grid as tile grid
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 32d9ac36-3f53-44bc-93af-c00ea778689a
📥 Commits

Reviewing files that changed from the base of the PR and between 13d77bc and a41745b.

📒 Files selected for processing (19)
  • Modules/lvgl-module/generate-icons.py
  • Modules/lvgl-module/include/lvgl/icons/names.h
  • Modules/lvgl-module/include/lvgl/icons/shared.h
  • Modules/lvgl-module/source/icon_names.c
  • Modules/lvgl-module/source/themes/lv_theme_material.c
  • Modules/lvgl-module/source/themes/lv_theme_material_mono.c
  • Modules/lvgl-module/themes/material.lss
  • Modules/lvgl-module/themes/material_mono.lss
  • Tactility/Private/Tactility/app/TileGrid.h
  • Tactility/Private/Tactility/app/files/State.h
  • Tactility/Private/Tactility/app/files/View.h
  • Tactility/Private/Tactility/app/launcher/LauncherMode.h
  • Tactility/Source/app/TileGrid.cpp
  • Tactility/Source/app/files/FilesApp.cpp
  • Tactility/Source/app/files/State.cpp
  • Tactility/Source/app/files/View.cpp
  • Tactility/Source/app/launcher/AppsMode.cpp
  • Tactility/Source/app/launcher/Launcher.cpp
  • Tactility/Source/app/launcher/SettingsMode.cpp
💤 Files with no reviewable changes (3)
  • Tactility/Private/Tactility/app/files/State.h
  • Tactility/Source/app/files/State.cpp
  • Tactility/Source/app/files/FilesApp.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough
📝 Walkthrough

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to a4174

No identified issue prevents merging the tile-grid and files-app update after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 15.15% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 99 functions across 14 files. (2 skipped:… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: refactoring the files app. It also aligns with the stated PR objective.
Full details: Docstring Coverage

Explanation

Docstring coverage is 15.15% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 99 functions across 14 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KenVanHoeylandt KenVanHoeylandt changed the title Refactor files app Files app refactored Oct 8, 2026
@KenVanHoeylandt
KenVanHoeylandt merged commit 7413888 into main Oct 9, 2026
68 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the files-app-refactored branch October 9, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant