Notes revamped, icon fixes, Tab5 fixes

[KenVanHoeylandt]

Summary by CodeRabbit

• New Features
  • Notes now provides an overflow menu with New, Save, Save As, and Open actions. The menu closes after an action, when you press Escape, or when you tap the note text; focus returns to the overflow button when appropriate.
  • Added Save, Save As, and Folder Open icons to support the Notes menu.
• Updates
  • Updated display settings on Tab5 devices.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3f4c9dd9-f4ac-4662-88b8-6fecbacba2d1

📥 Commits

Reviewing files that changed from the base of the PR and between 45c110d and 4064f4c.

📒 Files selected for processing (1)

• Tactility/Source/app/notes/Notes.cpp

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 00a0e543-e438-4d41-8aeb-626b955402bf

📥 Commits

Reviewing files that changed from the base of the PR and between 7413888 and 45c110d.

⛔ Files ignored due to path filters (1)

• Data/system/fonts/MaterialSymbolsRounded.ttf is excluded by !**/*.ttf

📒 Files selected for processing (8)

• Data/system/fonts/MaterialSymbolsRounded.codepoints
• Devices/m5stack-tab5/Source/devices/devices_v2.cpp
• Devices/m5stack-tab5/Source/devices/devices_v3.cpp
• Modules/lvgl-module/generate-icons.py
• Modules/lvgl-module/include/lvgl/icons/names.h
• Modules/lvgl-module/include/lvgl/icons/shared.h
• Modules/lvgl-module/source/icon_names.c
• Tactility/Source/app/notes/Notes.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The Notes app replaces its toolbar dropdown with an overflow button and floating action overlay. The overlay provides New, Save, Save As, and Open actions, with Save shown only when a file path is set. The shared icon resources add Material Symbols entries and shared LVGL icons. The ST7123 and ST7121 Tab5 display configurations change their lane bitrate to 1040 Mbps and DPI clock to 80 MHz.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 45c11

No actionable merge-blocking issue is established. The updated Tab5 display timings still warrant normal hardware validation.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 7.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 7 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title accurately identifies the three main change areas: the Notes app revision, icon updates, and Tab5 display fixes. It is concise and specific enough for the changeset.

Full details: Docstring Coverage

Explanation

Docstring coverage is 7.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 7 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}