Repository navigation
CL-32 v0.4 implementation + split v0.2/v0.3 - #683
Merged
Merged
Conversation
+ cleanup of unused settings (launcher app, inverting statusbar colors)
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds CL-32 v0.4 device support and an ST7305 display driver, and moves CL-32 v0.2/v0.3 hardware detection into its own module. It adds a refresh action and conditional network-list rebuilding to Wi-Fi management. It removes launcher ID and status-bar color inversion settings from device configuration and build generation, and adds a fixed launcher fallback. It also updates keyboard mappings, backlight callbacks, supported text-file extensions, note styling, Material theme transitions, and terminal LVGL selection. Priority: ➖ Normal Merge Risk: 🔵 Low · up to A username without its Docker Hub token can block the SDK build, but builds with both credentials or neither are unaffected. Ensure the secrets are paired or skip login unless both are present. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 14.81% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 81 functions across 37 files. (2 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check |  |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description Check | |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main changes: implementing CL-32 v0.4 and splitting the CL-32 v0.2/v0.3 device project. |
Full details: Docstring Coverage
Explanation
Docstring coverage is 14.81% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 81 functions across 37 files. (2 skipped: 2 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
203a0e86-66e8-4576-b256-a7cd2d612caa
📒 Files selected for processing (113)
Buildscripts/Flashing/merge.shCMakeLists.txtDevices/btt-panda-touch/device.propertiesDevices/cl32-v02-v03/CMakeLists.txtDevices/cl32-v02-v03/LICENSE-Apache-2.0.mdDevices/cl32-v02-v03/cl32-v02-v03.dtsDevices/cl32-v02-v03/device.propertiesDevices/cl32-v02-v03/module.yamlDevices/cl32-v02-v03/source/cl32_detect.cppDevices/cl32-v02-v03/source/cl32_detect.hDevices/cl32-v02-v03/source/cl32_v2.hDevices/cl32-v02-v03/source/cl32_v2_keyboard.cppDevices/cl32-v02-v03/source/cl32_v2_keyboard.hDevices/cl32-v02-v03/source/cl32_v3.hDevices/cl32-v02-v03/source/cl32_v3_keyboard.cppDevices/cl32-v02-v03/source/cl32_v3_keyboard.hDevices/cl32-v02-v03/source/module.cppDevices/cl32-v04/CMakeLists.txtDevices/cl32-v04/LICENSE-Apache-2.0.mdDevices/cl32-v04/bindings/cl32-v4-keyboard.yamlDevices/cl32-v04/bindings/cl32-v4-power.yamlDevices/cl32-v04/cl32-v04.dtsDevices/cl32-v04/device.propertiesDevices/cl32-v04/module.yamlDevices/cl32-v04/source/bindings/cl32_v4_keyboard.hDevices/cl32-v04/source/bindings/cl32_v4_power.hDevices/cl32-v04/source/cl32_v4.hDevices/cl32-v04/source/cl32_v4_keyboard.cppDevices/cl32-v04/source/cl32_v4_keyboard.hDevices/cl32-v04/source/cl32_v4_power.cppDevices/cl32-v04/source/cl32_v4_power.hDevices/cl32-v04/source/module.cppDevices/cl32/source/cl32_detect.cppDevices/cl32/source/cl32_v4_keyboard.hDevices/cl32/source/cl32_v4_power.hDevices/cyd-2432s022c/device.propertiesDevices/cyd-2432s024c/device.propertiesDevices/cyd-2432s024r/device.propertiesDevices/cyd-2432s028r/device.propertiesDevices/cyd-2432s028rv3/device.propertiesDevices/cyd-2432s032c/device.propertiesDevices/cyd-3248s035c/device.propertiesDevices/cyd-4848s040c/device.propertiesDevices/cyd-8048s043c/device.propertiesDevices/cyd-e32r28t/device.propertiesDevices/cyd-e32r32p/device.propertiesDevices/elecrow-crowpanel-advance-28/device.propertiesDevices/elecrow-crowpanel-advance-35/device.propertiesDevices/elecrow-crowpanel-advance-50/device.propertiesDevices/elecrow-crowpanel-basic-28/device.propertiesDevices/elecrow-crowpanel-basic-35/device.propertiesDevices/elecrow-crowpanel-basic-50/device.propertiesDevices/es3c28p/device.propertiesDevices/generic-esp32/device.propertiesDevices/generic-esp32c6/device.propertiesDevices/generic-esp32p4/device.propertiesDevices/generic-esp32s3/device.propertiesDevices/guition-jc1060p470ciwy/device.propertiesDevices/guition-jc2432w328c/device.propertiesDevices/guition-jc8048w550c/device.propertiesDevices/heltec-wifi-lora-32-v3/device.propertiesDevices/lilygo-t5-epd47-s3/device.propertiesDevices/lilygo-tdeck-max/device.propertiesDevices/lilygo-tdeck-plus/device.propertiesDevices/lilygo-tdeck-pro/device.propertiesDevices/lilygo-tdeck/device.propertiesDevices/lilygo-tdisplay-s3/device.propertiesDevices/lilygo-tdisplay/device.propertiesDevices/lilygo-tdongle-s3/device.propertiesDevices/lilygo-tembed-cc1101-plus/device.propertiesDevices/lilygo-thmi/device.propertiesDevices/lilygo-tlora-pager/device.propertiesDevices/m5stack-cardputer-adv/device.propertiesDevices/m5stack-cardputer/device.propertiesDevices/m5stack-core2/device.propertiesDevices/m5stack-cores3/device.propertiesDevices/m5stack-papers3/device.propertiesDevices/m5stack-stackchan/device.propertiesDevices/m5stack-stickc-plus2/device.propertiesDevices/m5stack-sticks3/device.propertiesDevices/m5stack-tab5/device.propertiesDevices/seeed-wio-tracker-l2-pro/device.propertiesDevices/simulator/device.propertiesDevices/tulip-4r11/device.propertiesDevices/unphone/device.propertiesDevices/waveshare-esp32-s3-geek/device.propertiesDevices/waveshare-s3-lcd-13/device.propertiesDevices/waveshare-s3-touch-lcd-128/device.propertiesDevices/waveshare-s3-touch-lcd-147/device.propertiesDevices/waveshare-s3-touch-lcd-43/device.propertiesDevices/wireless-tag-wt32-sc01-plus/device.propertiesDrivers/st7305-module/CMakeLists.txtDrivers/st7305-module/LICENSE-Apache-2.0.mdDrivers/st7305-module/README.mdDrivers/st7305-module/bindings/sitronix,st7305.yamlDrivers/st7305-module/include/bindings/st7305.hDrivers/st7305-module/include/drivers/st7305.hDrivers/st7305-module/include/st7305_module.hDrivers/st7305-module/module.yamlDrivers/st7305-module/source/module.cppDrivers/st7305-module/source/st7305.cppModules/lvgl-module/source/themes/lv_theme_material.cModules/lvgl-module/themes/material.lssTactility/KconfigTactility/Private/Tactility/app/wifimanage/Bindings.hTactility/Private/Tactility/app/wifimanage/State.hTactility/Private/Tactility/app/wifimanage/View.hTactility/Source/app/boot/BootInit.cppTactility/Source/app/wifimanage/State.cppTactility/Source/app/wifimanage/View.cppTactility/Source/app/wifimanage/WifiManage.cppTactility/Source/lvgl/Statusbar.cppdevice.py
💤 Files with no reviewable changes (66)
- Devices/seeed-wio-tracker-l2-pro/device.properties
- Devices/waveshare-esp32-s3-geek/device.properties
- Devices/cyd-2432s022c/device.properties
- CMakeLists.txt
- Devices/elecrow-crowpanel-basic-28/device.properties
- Devices/cyd-2432s024r/device.properties
- Devices/m5stack-sticks3/device.properties
- Devices/unphone/device.properties
- Devices/lilygo-tembed-cc1101-plus/device.properties
- Devices/cyd-2432s024c/device.properties
- Devices/lilygo-tdongle-s3/device.properties
- Devices/lilygo-tdeck/device.properties
- Devices/m5stack-stickc-plus2/device.properties
- Devices/elecrow-crowpanel-advance-28/device.properties
- Devices/waveshare-s3-touch-lcd-43/device.properties
- Devices/tulip-4r11/device.properties
- Devices/lilygo-tdisplay-s3/device.properties
- Devices/simulator/device.properties
- Devices/btt-panda-touch/device.properties
- Devices/cyd-8048s043c/device.properties
- Devices/wireless-tag-wt32-sc01-plus/device.properties
- Devices/elecrow-crowpanel-basic-35/device.properties
- Devices/cyd-2432s028r/device.properties
- Devices/generic-esp32/device.properties
- Devices/m5stack-cardputer-adv/device.properties
- Devices/cyd-3248s035c/device.properties
- Devices/waveshare-s3-touch-lcd-128/device.properties
- Devices/cyd-2432s032c/device.properties
- Devices/guition-jc2432w328c/device.properties
- Devices/cyd-4848s040c/device.properties
- Devices/cyd-2432s028rv3/device.properties
- Devices/m5stack-cores3/device.properties
- Devices/waveshare-s3-lcd-13/device.properties
- Devices/waveshare-s3-touch-lcd-147/device.properties
- Devices/lilygo-tdeck-plus/device.properties
- Devices/m5stack-cardputer/device.properties
- Devices/lilygo-thmi/device.properties
- Devices/cyd-e32r28t/device.properties
- Devices/generic-esp32p4/device.properties
- Devices/m5stack-stackchan/device.properties
- Devices/es3c28p/device.properties
- Devices/generic-esp32s3/device.properties
- Devices/lilygo-tdeck-pro/device.properties
- Devices/m5stack-papers3/device.properties
- Devices/elecrow-crowpanel-basic-50/device.properties
- Devices/cyd-e32r32p/device.properties
- Devices/guition-jc8048w550c/device.properties
- Devices/m5stack-tab5/device.properties
- Devices/cl32-v02-v03/source/cl32_detect.h
- Devices/elecrow-crowpanel-advance-35/device.properties
- Devices/cl32/source/cl32_v4_keyboard.h
- Devices/lilygo-tdisplay/device.properties
- Devices/cl32/source/cl32_v4_power.h
- Devices/heltec-wifi-lora-32-v3/device.properties
- device.py
- Devices/guition-jc1060p470ciwy/device.properties
- Devices/elecrow-crowpanel-advance-50/device.properties
- Devices/lilygo-tlora-pager/device.properties
- Tactility/Source/lvgl/Statusbar.cpp
- Devices/m5stack-core2/device.properties
- Devices/cl32-v04/source/cl32_v4.h
- Devices/generic-esp32c6/device.properties
- Devices/lilygo-tdeck-max/device.properties
- Devices/lilygo-t5-epd47-s3/device.properties
- Devices/cl32/source/cl32_detect.cpp
- Tactility/Kconfig
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
076467d9-7d6a-45ef-bb8e-fed11fa2a0ae
📒 Files selected for processing (2)
.github/actions/build-sdk/action.ymlTactility/Source/app/terminal/main.cpp
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drivers/st7305-modulecl32device project tocl32-v02-v03and removed v0.4 driverscl32-v04: display, keyboard, backlight/frontlight driver and power supplyTT_LAUNCHER_APP_ID(it was always the same setting)TT_LVGL_STATUSBAR_COLORS_INVERTED(unused since recent changes)merge.shexecutable