You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Three frontend blob/main/docs links have no existence guard, including one inside a copyable code sample #2424
Three user-facing blob/main/docs/... links have no guard that their target exists. The guard already exists for two others, so this is about extending a working pattern rather than inventing one.
Measured at origin/main. Five hardcoded references:
The other two existsSync-using frontend tests (v2-layout-invariants, readmeFrames) reference none of the three. All three targets do exist today, so this is a latent gap, not a live 404: a rename under docs/ would send people to a GitHub 404 with nothing red.
The guides.json one is the most interesting and the easiest to miss. It is not a component link — it sits inside a copyable bash sample, as a comment:
# Attach Codex to one pod. OpenCode also needs a provider file: github.com/Team-Commonly/commonly/blob/main/docs/cli/opencode.md
So a component-only grep does not find it, and the copy a user pastes carries the path.
Fix: one test that collects every blob/main/docs/... occurrence under frontend/src (components and content both), extracts the path, and existsSync-es it — which also makes the set self-maintaining, where today each new link needs someone to remember to add it to a list. The backend has the same guard for a different surface (nativeAgents.scoutKnowledge.test.js:131-132), so the convention is established at both ends.
Found while reviewing #2411 (#2411 (review)). For the record, my review note there said four links and none guarded; re-measuring before filing found five, and two guarded — the guard landed before that PR merged.
Activity