Skip to content

ci(adr): resolve the ADR checker from the effective tree, not the PR head #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyshen0722 merged 1 commit into from
Sep 2, 2026
Merged

ci(adr): resolve the ADR checker from the effective tree, not the PR head #1508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/adr-numbering-guard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,23 @@ jobs:
esac
done

node scripts/verify-adr-numbering.js --dir "$eff/docs/adr"
# The checker itself has to be resolved the same way as the ADRs, and
# for the same reason. On a `pull_request` event GitHub takes the
# WORKFLOW from the merge ref but this job checks out the PR HEAD —
# so every PR branched before this guard landed has the workflow file
# and not the script, and `node scripts/...` died with
# MODULE_NOT_FOUND. That reds the PR with no ADR output at all, which
# reads as a broken guard rather than a real collision (#1504).
# Effective content: the PR's version if it changed the script,
# otherwise main's.
bin=$(mktemp -d)
if git cat-file -e "HEAD:scripts/verify-adr-numbering.js" 2>/dev/null; then
git show "HEAD:scripts/verify-adr-numbering.js" > "$bin/verify-adr-numbering.js"
else
git show "FETCH_HEAD:scripts/verify-adr-numbering.js" > "$bin/verify-adr-numbering.js"
fi

node "$bin/verify-adr-numbering.js" --dir "$eff/docs/adr"

# The check above cannot see a collision between two PRs that are both
# still open — neither tree contains the other's file. That is the state
Expand Down
Loading