Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ module.exports = {
'src/v2/components/V2AdminUsers.tsx',
'src/v2/components/V2AgentBYO.tsx',
'src/v2/components/V2FeedbackMenu.tsx',
'src/v2/components/V2PodInspector.tsx',
'src/v2/components/V2Inspector.tsx',
'src/v2/components/V2PodsSidebar.tsx',
'src/v2/components/V2YourTeamPage.tsx',
],
Expand Down
21 changes: 21 additions & 0 deletions frontend/src/i18n/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -957,6 +957,27 @@
"stat_one": "{{complete}} of {{total}} task complete",
"stat_other": "{{complete}} of {{total}} tasks complete"
},
"workspace": {
"ariaLabel": "Pod inspector",
"close": "Close inspector",
"agentsIn": "agents in {{pod}}",
"noAgents": "no agents yet",
"needsYou": "needs you",
"nothingOpen": "Nothing open.",
"nothingWorking_one": "Nothing. {{agents}} is working.",
"nothingWorking_other": "Nothing. {{agents}} are working.",
"boardToday": "board · today",
"boardCounts": "{{open}} open · {{inProgress}} in progress · {{done}} done",
"wip": "wip",
"members": "members",
"manage": "manage",
"agentStatus": {
"needsYou": "needs you · {{title}}",
"workingTask": "working · {{title}}",
"working": "working",
"idle": "idle"
}
},
"goal": {
"title": "Goal",
"empty": "No goal set yet."
Expand Down
20 changes: 20 additions & 0 deletions frontend/src/i18n/locales/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -954,6 +954,26 @@
"stat": "{{total}} 个任务中已完成 {{complete}} 个",
"stat_other": "{{total}} 个任务中已完成 {{complete}} 个"
},
"workspace": {
"ariaLabel": "Pod 检视器",
"close": "关闭检视器",
"agentsIn": "{{pod}} 中的智能体",
"noAgents": "暂无智能体",
"needsYou": "需要你处理",
"nothingOpen": "没有待处理项。",
"nothingWorking_other": "没有需要你处理的事项。{{agents}} 正在工作。",
"boardToday": "看板 · 今天",
"boardCounts": "{{open}} 开放 · {{inProgress}} 进行中 · {{done}} 完成",
"wip": "进行中",
"members": "成员",
"manage": "管理",
"agentStatus": {
"needsYou": "需要你处理 · {{title}}",
"workingTask": "进行中 · {{title}}",
"working": "进行中",
"idle": "空闲"
}
},
"goal": {
"title": "目标",
"empty": "尚未设定目标。"
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/v2/__tests__/V2FirstRunHero.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jest.mock('../components/V2NavRail', () => () => (
</nav>
));
jest.mock('../components/V2PodsSidebar', () => () => <aside>Pods</aside>);
jest.mock('../components/V2PodInspector', () => () => <aside>Inspector</aside>);
jest.mock('../components/V2Inspector', () => () => <aside>Inspector</aside>);
jest.mock('../components/V2InviteModal', () => () => null);
jest.mock('../components/V2PodChat', () => ({ firstRunVisible }: { firstRunVisible?: boolean }) => (
<main data-testid="pod-chat">
Expand Down
108 changes: 108 additions & 0 deletions frontend/src/v2/__tests__/V2Inspector.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
/* eslint-disable react/display-name */
import React from 'react';
import {
fireEvent, render, screen, waitFor,
} from '@testing-library/react';
import { MemoryRouter } from 'react-router-dom';
import V2Inspector from '../components/V2Inspector';

const mockNavigate = jest.fn();
const mockGet = jest.fn();

jest.mock('react-router-dom', () => {
const actual = jest.requireActual('react-router-dom');
return { ...actual, useNavigate: () => mockNavigate };
});

jest.mock('../hooks/useV2Api', () => ({
useV2Api: () => ({ get: mockGet }),
}));

jest.mock('../components/V2Avatar', () => ({ name }: { name: string }) => <span data-testid="avatar">{name}</span>);

const detail = {
pod: { _id: 'pod-1', name: 'Sharpen', type: 'team' },
members: [],
agents: [
{ agentName: 'wren', instanceId: 'default', displayName: 'Wren', status: 'working' },
{ agentName: 'kai', instanceId: 'default', displayName: 'Kai' },
],
messages: [], loading: false, error: null, sendError: null,
hasMore: false, loadingOlder: false, loadOlder: jest.fn(), refresh: jest.fn(), sendMessage: jest.fn(),
};

const renderInspector = (props: Partial<React.ComponentProps<typeof V2Inspector>> = {}) => render(
<MemoryRouter>
<V2Inspector detail={detail as any} onOpenInvite={jest.fn()} {...props} />
</MemoryRouter>,
);

describe('V2Inspector', () => {
beforeEach(() => {
jest.clearAllMocks();
mockGet.mockImplementation((url: string) => {
if (url === '/api/activity/decision-queue') {
return Promise.resolve({ items: [{
id: 'decision-1', kind: 'decision', title: 'Slack default mode', actorName: 'Wren', podId: 'pod-1', messageId: 'message-7',
}] });
}
if (url === '/api/v1/tasks/pod-1') {
return Promise.resolve({ tasks: [
{ taskId: 'TASK-131', title: 'Build the card', status: 'in_progress', assignee: 'kai' },
{ taskId: 'TASK-132', title: 'Verify the card', status: 'pending' },
{ taskId: 'TASK-130', title: 'Ship the event', status: 'done' },
] });
}
return Promise.resolve({});
});
});

test('renders the three artboard cards from the pod’s existing data', async () => {
renderInspector();

expect(screen.getByRole('heading', { name: 'agents in sharpen' })).toBeInTheDocument();
expect(screen.getByRole('heading', { name: 'needs you' })).toBeInTheDocument();
expect(screen.getByRole('heading', { name: 'board · today' })).toBeInTheDocument();
expect(await screen.findByText('Slack default mode')).toBeInTheDocument();
expect(screen.getByText('1 open · 1 in progress · 1 done')).toBeInTheDocument();
expect(screen.getByText('needs you · Slack default mode')).toBeInTheDocument();
expect(screen.getByText('working · Build the card')).toBeInTheDocument();
expect(screen.queryByRole('tab')).not.toBeInTheDocument();
});

test('links attention, board, profile, invite, and manage exits without legacy tabs', async () => {
const onOpenInvite = jest.fn();
renderInspector({ onOpenInvite });

fireEvent.click(await screen.findByRole('button', { name: 'Slack default mode Wren' }));
expect(mockNavigate).toHaveBeenCalledWith('/v2/pods/pod-1#message-message-7');

fireEvent.click(screen.getByRole('button', { name: '1 open · 1 in progress · 1 done' }));
expect(mockNavigate).toHaveBeenCalledWith('/v2/pods/pod-1/board');

fireEvent.click(screen.getByRole('button', { name: /Wren needs you/ }));
expect(mockNavigate).toHaveBeenCalledWith('/v2/agent/wren/default');

fireEvent.click(screen.getByRole('button', { name: 'members' }));
expect(onOpenInvite).toHaveBeenCalledTimes(1);
fireEvent.click(screen.getByRole('button', { name: 'manage' }));
expect(mockNavigate).toHaveBeenCalledWith('/v2/agents/manage?podId=pod-1');
});

test('does not render a stale attention item from another pod', async () => {
mockGet.mockImplementation((url: string) => {
if (url === '/api/activity/decision-queue') return Promise.resolve({ items: [{ id: 'other', kind: 'decision', title: 'Other pod', podId: 'pod-2' }] });
return Promise.resolve({ tasks: [] });
});
renderInspector();
await waitFor(() => expect(screen.getByText('Nothing. Wren is working.')).toBeInTheDocument());
expect(screen.queryByText('Other pod')).not.toBeInTheDocument();
});

test('uses the settled-workspace empty copy when no agent is working', async () => {
mockGet.mockImplementation(() => Promise.resolve({ items: [], tasks: [] }));
renderInspector({ detail: { ...detail, agents: [] } as any });

expect(await screen.findByText('Nothing open.')).toBeInTheDocument();
});
});
2 changes: 1 addition & 1 deletion frontend/src/v2/__tests__/V2InviteDmGate.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jest.mock('../../context/AuthContext', () => ({

jest.mock('../components/V2NavRail', () => () => null);
jest.mock('../components/V2PodsSidebar', () => () => null);
jest.mock('../components/V2PodInspector', () => () => null);
jest.mock('../components/V2Inspector', () => () => null);
jest.mock('../components/V2InviteModal', () => function MockV2InviteModal({ open, initialTab }) {
return open ? <div data-testid="invite-modal-tab">{initialTab}</div> : null;
});
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/v2/__tests__/V2LayoutSelection.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jest.mock('../../context/AuthContext', () => ({
jest.mock('../components/V2NavRail', () => () => null);
jest.mock('../components/V2PodsSidebar', () => () => null);
jest.mock('../components/V2PodChat', () => () => null);
jest.mock('../components/V2PodInspector', () => () => null);
jest.mock('../components/V2Inspector', () => () => null);
jest.mock('../components/V2InviteModal', () => () => null);
jest.mock('../components/V2FirstRunHero', () => () => null);

Expand Down
49 changes: 0 additions & 49 deletions frontend/src/v2/__tests__/V2PodInspectorAgentRoom.test.tsx

This file was deleted.

98 changes: 0 additions & 98 deletions frontend/src/v2/__tests__/V2PodInspectorMemberProfile.test.tsx

This file was deleted.

Loading
Loading