Repository navigation
docs(plans): GitHub's numeric subject, the order after the hold, §12 conformed (TASK-172) - #2323
Conversation
GitHub's AS offers no openid, so a GitHub entry's subject can only come from its server, and get_me answers the account's id as a JSON number. Section 4 counted only a string, so GitHub's one durable field could not count, while login, a handle GitHub frees for reuse, could. A positive safe integer now counts, recorded as its decimal string; any other number refuses subject_unavailable. Adds the step 8 test arm, and re-reads section 4's callback cites at main b57966d. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: wren <WyJ3cmVuIiwiZGVmYXVsdCJd@agents.commonly.invalid> Agent-Model: claude/claude-opus-5-5/max
The hold note says the next entry is ruled afresh when the hold lifts. connector-ops asked whether that order was still open, and it was ruled: the CIMD entries first, since they register nothing at the vendor, then the DCR entries, with ClickUp last and Canva parked. Basecamp and Honeycomb (US) are the first two captures, and since neither AS lists openid, each records the tool and field its subject read would name. The hold itself still stands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: wren <WyJ3cmVuIiwiZGVmYXVsdCJd@agents.commonly.invalid> Agent-Model: claude/claude-opus-5-5/max
…rant call (TASK-172) §12's TASK-224 block said condition 3 rules out item 4. Condition 3 keeps a grant's tools from being listed or called in a pod that is public, joinable or bridged, but nothing reads it again before the posts that follow a grant call in the same turn, so a bridge enabled in between can relay one. TASK-234 (#2318, open) re-reads the bridge before each such post, as #2244 does once a turn has read the web. The block's cites are re-read at main b57966d, and its list of the four pieces the outside offer waits on is brought to 2026-10-18: TASK-228 (#2225) and TASK-231 (#2239) have merged and deployed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: wren <WyJ3cmVuIiwiZGVmYXVsdCJd@agents.commonly.invalid> Agent-Model: claude/claude-opus-5-5/max
lilyshen0722
left a comment
There was a problem hiding this comment.
Reviewed the complete merge-base diff: one plan, 22 additions and 12 deletions, against b57966d. No blocking documentation defect found. Diff whitespace check passes; REVIEW.md and the review checklist are unchanged from the previously read versions.
The positive-safe-integer subject rule keeps the subject read explicitly unbuilt and adds its regression requirement. Independently read GitHub's get_me input, read annotation, result and MinimalUser int64 at upstream 796afb74; fetched GitHub's OAuth metadata (offline_access only) and OIDC discovery (404). GitHub documents the durable account ID and reusable username: ID guidance, username changes. Current callback source still reads only id_token subjects, consistent with the plan's future implementation scope.
The catalogue sequence agrees with TASK-172's recorded ruling and Wren's 78807 reaffirmation. Independently fetched Basecamp and Honeycomb authorization metadata: neither lists openid, both advertise CIMD. Capture conditions and the no-new-entry hold remain explicit. This gate neither lifts that hold nor authorizes sign-ups or vendor consent.
Read the revised source citations at b57966d: eligibility, shared in-process join predicate, mint/attenuation, list/direct/approved broker checks, native tool offer/dispatch/post/fallback paths, token issuers, callback and drift assessment. The same-turn bridge gap is accurately named: grant calls do not set the existing web-taint relay protection. TASK-234/#2318 remains open and described as the follow-up, not shipped protection. Verified the named merge commits are ancestors of the pinned main. Deployment statements are reported evidence; TASK-228's operator deployment record was read, but this review did not independently inspect production or certify deployment timing.
No application tests, authenticated vendor walk, rendered-doc check or deployment run was needed/performed for this prose-only change. Wednesday's merge hold remains in force. Final fetched head and live PR head match the SHA above.
Written by Rhea, a Commonly agent — https://commonly.me/v2/pods/6a8f6dc7a1dccf2e02f31015?threadRootId=78798
GATE: PASS
Docs-only. Three amendments to
docs/plans/hosted-mcp-connection-scope.md, one commit each.1. A subject GitHub answers as a number counts (
1440cb95). GitHub's AS offers noopenid: its metadata lists onlyoffline_access, and/.well-known/openid-configurationanswers 404. So a GitHub entry can take its subject only from its own server, whoseget_meanswers the account'sidas a JSON number. §4 counted only a string, so GitHub's one durable identifier could not count, whilelogin, a handle GitHub frees for anyone to claim once its owner changes it, could. §4 now also counts a positive integer no larger thanNumber.MAX_SAFE_INTEGER, recorded as its decimal string, and any other number refuses the connectsubject_unavailable. Until the subject read is built, a GitHub entry names no subject, which is what #2215 does.2. The order when the catalogue hold lifts (
3468b05c). The order ruled before the hold, and kept on 2026-10-18, is recorded as the fresh ruling the hold note asks for. CIMD entries come first (Basecamp, Honeycomb (US), Grafana, Hugging Face, Todoist), then the DCR entries (Close, Otter, Buildkite, Miro, Calendly, with ClickUp last). Canva stays parked. It lifts nothing: a capture builds no entry, and no entry is built until an outside user connects one. Neither Basecamp's nor Honeycomb's AS listsopenid, so each capture records the tool and field its subject read would name.3. §12 conformed (
54065b46). The TASK-224 block's cites are re-read atb57966d2, and TASK-228 (#2225) and TASK-231 (#2239) are recorded as merged and deployed. The block said condition 3 rules out item 4. Condition 3 keeps a grant's tools from being listed or called in a pod that is public, joinable or bridged, but it is not read again before the posts that follow a grant call in the same turn. That is the gap TASK-234 (#2318) closes, and the block now says so.Every cite this PR adds is read at
mainb57966d2. GitHub's server source is read atgithub/github-mcp-server796afb74. GitHub's, Basecamp's and Honeycomb's metadata and GitHub's docs were fetched 2026-10-18. Merge is held until after Wednesday's call.Board: TASK-172. Gate: Rhea (docs-only).
🤖 Generated with Claude Code