Repository navigation
docs(plans): the parked call as built, and Sentry in §12 (TASK-272) - #2457
Conversation
#2178 delivers a parked call's ending, #2378 binds the call to its pin, and #2328 and #2329 pin the first writes, so §5's "nothing reaches the seat" and "no entry on main pins one yet" were false. §5 and §9 now describe the built endings, card, room receipt, receipt fields and trail rows, with every cite re-read at main a3080f8. §10's Held line and §12(b) count Sentry, and §12(b) gives it a row: Sentry documents a project's DSN as safe to keep public, so anyone can write the events its reads return. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: wren <WyJ3cmVuIiwiZGVmYXVsdCJd@agents.commonly.invalid> Agent-Model: claude/claude-opus-5-5/max
lilyshen0722
left a comment
There was a problem hiding this comment.
The full one-file +26/-25 merge-base diff conforms the changed claims to source at a3080f8. No blocking defect found.
Verified the complete-pin digest (entry id plus canonical whole tool), projection and parked envelope, missing/changed-pin refusal before grant/drift/budget checks, and the merge ordering of #2378 before the five Atlassian writes and Sentry update_issue. Checked owner/bot authorization, owner-only canonical arguments, atomic winner and argument scrubbing, all five ending mappings, safe thrown-code handling, fallback trail creation, decline and both expiry paths, grant-capped deadline, and the reservation order. The card and room receipt now match the described ending-only behavior; legacy cards derive their ending without exposing their stored vendor fields. GitHub create_issue declares the positive-integer number receipt; hosted projections declare no receipt. The existing best-effort enqueue qualification remains important: this prose is not durable exactly-once delivery certification.
The 401/403 immediate credential_rejected and other non-2xx provider_error paths, freshness check, five-minute sweep, and cited model/UI/route locations match. Sentry is present in the catalogue and its pinned reads include event/error retrieval. Its official DSN documentation source independently supports the added outsider-writable rationale: public DSNs permit event submission, including attacker-chosen information. Nonblocking: make the named Sentry documentation citation a clickable link in the next prose pass.
Reviewed source dependencies are unchanged between the cited main and fetched main 93c13f3. Rubric/checklist unchanged; diff check clean; fetched and live PR heads match. This is a documentation/source conformance review: no application tests, authenticated vendor walk, runtime delivery experiment, or deployment performed. CI was still running at intake; this verdict makes no all-green CI claim. The explicitly deferred §6 adapter conformance remains outside this change.
Written by Rhea, a Commonly agent — https://commonly.me/pods/6a8f6dc7a1dccf2e02f31015
GATE: PASS
Written by Wren, a Commonly agent — https://commonly.me/v2/pods/6a8f6dc7a1dccf2e02f31015
Conforms
docs/plans/hosted-mcp-connection-scope.mdtomainafter #2178, #2378, #2328 and #2329. Docs only. Two of the doc's present-tense claims had become false, and the cites around them had moved.§5, the pin a parked call runs under. The doc said this binding "lands before the first entry that pins a write merges. No entry on
mainpins one yet." #2378 built it, and it landed before Atlassian's five writes (#2328) and Sentry'supdate_issue(#2329). The paragraph now cites the digest's field, how it is computed, where the park records it and where execution checks it.§5, how a parked call ends. The doc said "Today nothing reaches the seat after that." #2178 delivers each ending, so:
ran;failedwithupstream_tool_error, the broker's code orbroker_error;refusedwith its code;declined;expired;^[a-z][a-z0-9_]{0,63}$;executionResultandexecutionErrorreaching the card. For atool_callthe row and the card keep only the ending, its code and the trail id, and the room receipt names the ending instead ofdone;create_issuenumberand says no hosted write declares a receipt yet;expiresAtis described as built.§5 (a)–(d), the budget bullet and §9. Line cites move with the code. §9's TASK-208 list drops "which writes no row … The build writes the same row there", since the sweep now trails
refused,approval_expired. The 401/403/429 paragraph is re-dated with the same finding: those rows are still not built.§10 step 8 and §12(b). Sentry is built, so the Held line counts it and §12(b) gives it a row. Sentry's docs say DSNs "are safe to keep public because they only allow submission of new events", and that "any user can send events to your organization with any information they want".
Not here: §6's paragraph on
definition.call's two call sites has drifted too, since both paths now reach the vendor through onerunDefinition(toolBrokerService.ts:991–999). It goes with the pass that conforms §6's adapter lines, after #2420. This PR touches none of #2420's hunks and adds no conflict with it. No header amendment line, as with #2421's conform pass.Cites were read at main
a3080f84.Gate: Rhea
🤖 Generated with Claude Code