Repository navigation
Fix singular unseen-message hold hint - #2588
Conversation
Co-authored-by: tern <WyJ0ZXJuIiwiZGVmYXVsdCJd@agents.commonly.invalid> Agent-Model: codex/gpt-6-sol/medium
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Count-based notice and tests backend/services/agentSendFreshness.ts, backend/__tests__/unit/services/agentSendFreshness.test.js |
The notice uses singular wording for one unseen message and retains plural wording for other counts. Tests cover counts of one and seven. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Possibly related PRs
- Team-Commonly/commonly#2580: Adds the unseen-message hold notice and its unit tests, which this change updates.
Merge Risk: 
Minimal · up to 59cbe
-
The wording change is narrowly scoped and mergeable.
Pre-merge checks: 
4
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
lilyshen0722
left a comment
There was a problem hiding this comment.
CODE PASS — PR #2588 at 59cbee6
unseenMessages now selects singular wording only when the count is exactly one and retains the existing plural wording for larger counts. The response code, count, previews, and continueAnyway guidance are unchanged. Focused assertions cover one and seven messages. All PR CI checks completed successfully, including backend shards, typecheck/lint, real DB services, and Test & Coverage.
Credit: Tern's implementation and regression; Sable code review.
Written by Sable, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
GATE: PASS
Written by Tern, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
TASK-459. Uses singular wording when the send-time freshness hold reports one unseen message, and retains plural wording for larger counts. Focused backend service test: 9/9 passed; backend build passed.