Skip to content

Fix singular unseen-message hold hint - #2588

Merged
lilyshen0722 merged 1 commit into
mainfrom
tern/task-459-singular-hint
Oct 24, 2026
Merged

lilyshen0722 merged 1 commit into
mainfrom
tern/task-459-singular-hint

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Written by Tern, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

TASK-459. Uses singular wording when the send-time freshness hold reports one unseen message, and retains plural wording for larger counts. Focused backend service test: 9/9 passed; backend build passed.

Co-authored-by: tern <WyJ0ZXJuIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: codex/gpt-6-sol/medium
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 83fe067 and 59cbee6.

Files selected for processing: 2
  • backend/__tests__/unit/services/agentSendFreshness.test.js
  • backend/services/agentSendFreshness.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The unseen-message notice now says “There is 1 unseen message.” when the count is one. For zero or multiple messages, it retains plural wording. Tests check the singular and plural cases.

Changes: Unseen-message notice

Layer / File(s) Summary
Count-based notice and tests
backend/services/agentSendFreshness.ts, backend/__tests__/unit/services/agentSendFreshness.test.js
The notice uses singular wording for one unseen message and retains plural wording for other counts. Tests cover counts of one and seven.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

Merge Risk: Minimal · up to 59cbe

The wording change is narrowly scoped and mergeable.

Pre-merge checks: Passed 4
Check name Status Explanation
Description check Passed The description accurately summarizes the singular wording change, retained plural wording, and reported test results.
Title check Passed The title clearly and concisely describes the main change to the unseen-message hold hint.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE PASS — PR #2588 at 59cbee6

unseenMessages now selects singular wording only when the count is exactly one and retains the existing plural wording for larger counts. The response code, count, previews, and continueAnyway guidance are unchanged. Focused assertions cover one and seven messages. All PR CI checks completed successfully, including backend shards, typecheck/lint, real DB services, and Test & Coverage.

Credit: Tern's implementation and regression; Sable code review.

Written by Sable, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS

@lilyshen0722
lilyshen0722 marked this pull request as ready for review October 24, 2026 07:17
@lilyshen0722
lilyshen0722 added this pull request to the merge queue Oct 24, 2026
Merged via the queue into main with commit bf0bd59 Oct 24, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant