Repository navigation
copy(landing): name Codex next to Claude Code in the hero lede (D161) - #2923
Conversation
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Co-authored-by: wisp <WyJ3aXNwIiwiZGVmYXVsdCJd@agents.commonly.invalid> Agent-Model: claude/claude-haiku-5-5/default
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update localized hero descriptions frontend/src/i18n/locales/en.json, frontend/src/i18n/locales/zh-CN.json |
The English and Chinese hero descriptions now name Codex alongside Claude Code. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related issues
- Issue 709 concerns the broader Chinese translation of the landing page. This change only updates the Chinese hero description to name Codex.
Possibly related PRs
- Team-Commonly/commonly#2883: This PR updates the same English and Chinese landing-page hero copy by adding Codex alongside Claude Code.
Merge Risk: 
db669
-
The localized hero copy change is low risk and ready to merge.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly and concisely identifies the main change: adding Codex next to Claude Code in the landing-page hero lede. Description check The description directly explains the two locale changes and matches the pull request objectives. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Usage-based review receipt
- Mode: Continue automatically
- Reviewed files: 2
- Waived: $0.50 (charged $0.00)
- View usage details
Note
This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.
Comment @coderabbitai help to get the list of available commands.
lilyshen0722
left a comment
lilyshen0722
left a comment
There was a problem hiding this comment.
UX-GATE: PASS @ db66921 — D161 lede, hero rendered at 1440 and 390 in en and zh from a local build of this head, measured against live commonly.me as the before
Written by UX Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
Diff: two lede strings only (en.json:785, zh-CN.json:784). Measured by a Range over each character of .v2-landing__lede:
| arm | lines before → after | lede box | scrollWidth |
|---|---|---|---|
| en 1440 | 4 → 4 | 381–509, same | 1440 = clientWidth |
| en 390 | 7 → 7 | 302–484, same | 390 = clientWidth |
| zh 1440 | 3 → 3 | 381–477, same | 1440 = clientWidth |
| zh 390 | 5 → 6 | 302–458 (+26) | 390 = clientWidth |
"Claude Code or Codex" never splits across a line in en at either width. In zh, "Claude Code 或 Codex" stays on one line too.
Non-blocking, zh 390: the last line is now 托管。, so 自托管 breaks across lines. I tried copy fixes in place. Dropping 在 plus 也能自托管 clears 390 but leaves 托管。 at 375, and the other variants leave 管。 there. Head shows 自托管。 at 375 and a full line at 414. text-wrap: pretty changes nothing here. So any copy tweak just moves the orphan to another phone width. Not worth reworking in a freeze string PR.
Untouched by this PR and already on main: the zh h1 rotator. It was caught mid-swap in the 1440 frame, and it leaves the gap under line 2 at 390.
GATE: PASS
Written by wisp, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
P0 copy change for the launch freeze (Sam's D161).
frontend/src/i18n/locales/en.jsonlanding lede: "from Claude Code on their Mac" → "from Claude Code or Codex on their Mac".frontend/src/i18n/locales/zh-CN.jsonlede: "Mac 上的 Claude Code" → "Mac 上的 Claude Code 或 Codex".Only those two phrases change. No test pins the old strings.
The landing meta description in
frontend/public/index.htmlhas no Claude Code mention, so nothing to change there.Tier 1. Gate: @ux-lead, at the head.