Repository navigation
chore(repo): remove the unused .codex settings file and the provider-service stubs - #2951
Conversation
…service stubs .codex/settings.local.json was a personal permissions allow-list that no tool reads. external/commonly-provider-services (343 lines of Discord, GroupMe, Slack and Telegram stubs) is built, mounted and run by nothing; only four docs pointed at it, and those lines go too. Docs and config only: no image changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MDs9DPbsFurockEzieszpM
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Remove provider services external/commonly-provider-services/README.md, external/commonly-provider-services/{discord,groupme,slack,telegram}-service/* |
The provider-service overview and the four services' READMEs, package manifests, and Express implementations are removed. |
Remove stub references docs/discord/README.md, docs/groupme/README.md, docs/telegram/README.md, docs/integrations/README.md |
The documentation no longer identifies the local provider stubs or mirror. The legacy in-platform provider statement remains. |
Codex Settings Removal
| Layer / File(s) | Summary |
|---|---|
Delete local Codex setting .codex/settings.local.json |
The local settings file that allowed Bash(git mv:*) is deleted. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related PRs
- Team-Commonly/commonly#2685: Both pull requests remove unused repository files and code.
- Team-Commonly/commonly#2861: That pull request identified
.codex/settings.local.jsonandexternal/as remaining cleanup scope; this pull request removes both.
Merge Risk: 
Minimal · up to 962f5
-
The cleanup is mergeable with no identified behavioral or operational risk.
Pre-merge checks: 
4
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
Gate on 962f56f. Removals are complete. No file at head refers to external/commonly-provider-services or .codex/settings.local.json, except .gitignore's .codex/skills.bak.* line and the ~/.codex home paths the PR says it keeps. The .gitmodules and gitlink for the two remaining external/ trees are untouched. The one added line is a docs sentence. Local copies under ~/.commonly/cli-live/docs are copies of the old docs, not live references. Written by Rhea, a Commonly agent — https://commonly.me/v2/pods/6a8f6dc7a1dccf2e02f31015 GATE: PASS at 962f56f |
lilyshen0722
left a comment
There was a problem hiding this comment.
Gated at head 962f56fd63.
The PR deletes .codex/settings.local.json and everything under external/commonly-provider-services/**, and edits four doc READMEs. Nothing outside the deleted tree imports or references it: I grepped for commonly-provider-services and .codex/ across backend, frontend, cli, commonly-mcp, k8s, scripts and .github at this head, and nothing references the deleted paths. The remaining .codex/ hits are the runtime home dir (~/.codex/auth.json, config.toml), not this repo file. .codex/skills was already retired in favour of .agents/skills (CLAUDE.md), and .agents/skills is untouched. CI is green (20 pass) and there are no CodeRabbit threads.
Written by Sable, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
GATE: PASS
What
A repo-root tidy for the freeze. Docs and config only, and no app image changes.
.codex/. It holds one file,.codex/settings.local.json, a personal permissions allow-list. Proof:git grep "codex/settings.local"returns 0 hits. The other.codexhits in backend and cli refer to the in-container or home~/.codexpath, not this directory.external/commonly-provider-services/(13 files, 343 lines of Discord, GroupMe, Slack and Telegram stubs). No workflow, Dockerfile, compose file orinstall.shbuilds, mounts or runs it. Proof:git grep -i "provider-services"outsidedocs/returns 0 hits. The four doc lines that pointed at it are removed here, and after this changegit grep commonly-provider-servicesreturns 0.backend/Dockerfile:66copiesexternalfrom the backend build context, which is a different directory from the repo-rootexternal/, so the image is unchanged.Kept on purpose
prod.shstays. A backend test (devRoutesOptIn.test.js:117) reads it, andbackend/config/devRoutes.tsanddocker-compose.dev.yml:74describe it, so it's still referenced.docker-compose.ymlstays.docs/deployment/SELF_HOSTED.md:35andDEPLOYMENT.mddocument it as the full self-host profile..claude/skillsstays. It's dangling in a fresh clone, but the shared local checkouts load project skills through it, and.agents/skillspoints at it. Deleting a tracked symlink removes it from every checkout on its next pull. That change needs a local-setup replacement first, plus an instruction-file update, so it's out of scope here.external/stays:commonly-agent-services(built by deploy-dev and staging, run by tests.yml) andlitellm(mounted by compose). The two submodules go with TASK-520.Test
Docs and config only. CI runs as usual.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MDs9DPbsFurockEzieszpM