Skip to content

chore(repo): remove the unused .codex settings file and the provider-service stubs - #2951

Merged
lilyshen0722 merged 1 commit into
mainfrom
chore/repo-root-tidy-d167
Oct 28, 2026
Merged

lilyshen0722 merged 1 commit into
mainfrom
chore/repo-root-tidy-d167

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

What

A repo-root tidy for the freeze. Docs and config only, and no app image changes.

  • Remove .codex/. It holds one file, .codex/settings.local.json, a personal permissions allow-list. Proof: git grep "codex/settings.local" returns 0 hits. The other .codex hits in backend and cli refer to the in-container or home ~/.codex path, not this directory.
  • Remove external/commonly-provider-services/ (13 files, 343 lines of Discord, GroupMe, Slack and Telegram stubs). No workflow, Dockerfile, compose file or install.sh builds, mounts or runs it. Proof: git grep -i "provider-services" outside docs/ returns 0 hits. The four doc lines that pointed at it are removed here, and after this change git grep commonly-provider-services returns 0.
  • backend/Dockerfile:66 copies external from the backend build context, which is a different directory from the repo-root external/, so the image is unchanged.

Kept on purpose

  • prod.sh stays. A backend test (devRoutesOptIn.test.js:117) reads it, and backend/config/devRoutes.ts and docker-compose.dev.yml:74 describe it, so it's still referenced.
  • docker-compose.yml stays. docs/deployment/SELF_HOSTED.md:35 and DEPLOYMENT.md document it as the full self-host profile.
  • .claude/skills stays. It's dangling in a fresh clone, but the shared local checkouts load project skills through it, and .agents/skills points at it. Deleting a tracked symlink removes it from every checkout on its next pull. That change needs a local-setup replacement first, plus an instruction-file update, so it's out of scope here.
  • The rest of external/ stays: commonly-agent-services (built by deploy-dev and staging, run by tests.yml) and litellm (mounted by compose). The two submodules go with TASK-520.

Test

Docs and config only. CI runs as usual.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MDs9DPbsFurockEzieszpM

…service stubs

.codex/settings.local.json was a personal permissions allow-list that no tool
reads. external/commonly-provider-services (343 lines of Discord, GroupMe,
Slack and Telegram stubs) is built, mounted and run by nothing; only four docs
pointed at it, and those lines go too. Docs and config only: no image changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MDs9DPbsFurockEzieszpM
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 12a3260 and 962f56f.

Files selected for processing: 18
  • .codex/settings.local.json
  • docs/discord/README.md
  • docs/groupme/README.md
  • docs/integrations/README.md
  • docs/telegram/README.md
  • external/commonly-provider-services/README.md
  • external/commonly-provider-services/discord-service/README.md
  • external/commonly-provider-services/discord-service/package.json
  • external/commonly-provider-services/discord-service/src/index.js
  • external/commonly-provider-services/groupme-service/README.md
  • external/commonly-provider-services/groupme-service/package.json
  • external/commonly-provider-services/groupme-service/src/index.js
  • external/commonly-provider-services/slack-service/README.md
  • external/commonly-provider-services/slack-service/package.json
  • external/commonly-provider-services/slack-service/src/index.js
  • external/commonly-provider-services/telegram-service/README.md
  • external/commonly-provider-services/telegram-service/package.json
  • external/commonly-provider-services/telegram-service/src/index.js
Files with no reviewable changes: 17
  • .codex/settings.local.json
  • external/commonly-provider-services/telegram-service/package.json
  • external/commonly-provider-services/groupme-service/package.json
  • external/commonly-provider-services/groupme-service/README.md
  • docs/groupme/README.md
  • docs/telegram/README.md
  • external/commonly-provider-services/discord-service/package.json
  • external/commonly-provider-services/discord-service/README.md
  • external/commonly-provider-services/slack-service/README.md
  • external/commonly-provider-services/slack-service/package.json
  • external/commonly-provider-services/README.md
  • docs/discord/README.md
  • external/commonly-provider-services/groupme-service/src/index.js
  • external/commonly-provider-services/discord-service/src/index.js
  • external/commonly-provider-services/slack-service/src/index.js
  • external/commonly-provider-services/telegram-service/README.md
  • external/commonly-provider-services/telegram-service/src/index.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

Walkthrough

The pull request removes local Discord, GroupMe, Slack, and Telegram provider services and their documentation references. It also deletes the local Codex settings file that allowed Bash(git mv:*).

Changes: Provider Stub Removal

Layer / File(s) Summary
Remove provider services
external/commonly-provider-services/README.md, external/commonly-provider-services/{discord,groupme,slack,telegram}-service/*
The provider-service overview and the four services' READMEs, package manifests, and Express implementations are removed.
Remove stub references
docs/discord/README.md, docs/groupme/README.md, docs/telegram/README.md, docs/integrations/README.md
The documentation no longer identifies the local provider stubs or mirror. The legacy in-platform provider statement remains.

Codex Settings Removal

Layer / File(s) Summary
Delete local Codex setting
.codex/settings.local.json
The local settings file that allowed Bash(git mv:*) is deleted.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 962f5

The cleanup is mergeable with no identified behavioral or operational risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely identifies both primary changes: removing the unused .codex settings file and the provider-service stubs.
Description check Passed The description directly explains the removed files, documentation updates, repository-scope checks, retained files, and test expectations. It is fully related to the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lilyshen0722

Copy link
Copy Markdown
Contributor Author

Gate on 962f56f.

Removals are complete. No file at head refers to external/commonly-provider-services or .codex/settings.local.json, except .gitignore's .codex/skills.bak.* line and the ~/.codex home paths the PR says it keeps. The .gitmodules and gitlink for the two remaining external/ trees are untouched. The one added line is a docs sentence. Local copies under ~/.commonly/cli-live/docs are copies of the old docs, not live references.

Written by Rhea, a Commonly agent — https://commonly.me/v2/pods/6a8f6dc7a1dccf2e02f31015

GATE: PASS at 962f56f

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gated at head 962f56fd63.

The PR deletes .codex/settings.local.json and everything under external/commonly-provider-services/**, and edits four doc READMEs. Nothing outside the deleted tree imports or references it: I grepped for commonly-provider-services and .codex/ across backend, frontend, cli, commonly-mcp, k8s, scripts and .github at this head, and nothing references the deleted paths. The remaining .codex/ hits are the runtime home dir (~/.codex/auth.json, config.toml), not this repo file. .codex/skills was already retired in favour of .agents/skills (CLAUDE.md), and .agents/skills is untouched. CI is green (20 pass) and there are no CodeRabbit threads.

Written by Sable, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS

@lilyshen0722
lilyshen0722 added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 89686e7 Oct 28, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant