Skip to content

test(seats): a credential streamed one character per delta never reaches the record #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyshen0722 merged 1 commit into from
Oct 30, 2026
Merged

test(seats): a credential streamed one character per delta never reaches the record #3011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions packages/seats/test/record-redact-stream.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,34 @@ test('two streams interleaved, each splitting the value, are scrubbed apart', ()
}
}));

// One character per delta: each delta is a prefix of the value, so it is held
// until the whole value has arrived (the marker) or the stream ends (the flush).
test('a credential streamed one character per delta never reaches the record', () => withStore(async (store, root) => {
const runId = 'run-chars-full';
const run = store.startRun({ runId });
run.redact([CANARY]);
for (const ch of CANARY) run.emit('agent.message_chunk', { text: ch });
run.emit('run.settled', { outcome: 'ok', durationMs: 1, attempts: 1 });
assertScrubbed(store, root, runId, [{ kind: 'agent.message_chunk', expected: '[redacted]' }]);
const events = store.readRun(runId);
const settledAt = events.findIndex((e) => e.kind === 'run.settled');
const marker = events.findIndex((e) => e.kind === 'agent.message_chunk' && e.data.text === '[redacted]');
assert.ok(marker >= 0 && marker < settledAt, 'the marker landed before run.settled');
}));

test('a credential cut one character short, streamed one character per delta, flushes as the marker before settle', () => withStore(async (store, root) => {
const runId = 'run-chars-short-of-one';
const run = store.startRun({ runId });
run.redact([CANARY]);
for (const ch of CANARY.slice(0, -1)) run.emit('agent.message_chunk', { text: ch });
run.emit('run.settled', { outcome: 'failed', failure: { kind: 'exited', detail: 'gone' }, durationMs: 1, attempts: 1 });
assertScrubbed(store, root, runId, [{ kind: 'agent.message_chunk', expected: '[redacted]' }]);
const events = store.readRun(runId);
const settledAt = events.findIndex((e) => e.kind === 'run.settled');
const marker = events.findIndex((e) => e.kind === 'agent.message_chunk' && e.data.text === '[redacted]');
assert.ok(marker >= 0 && marker < settledAt, 'the held tail flushed before run.settled');
}));

test('a stream that ends mid-value writes the marker before settle, never the prefix', () => withStore(async (store, root) => {
const run = store.startRun({ runId: 'run-held-settle' });
run.redact([CANARY]);
Expand Down
Loading