Skip to content

test(mentions): owner mentioning their own never-connected agent gets the line (TASK-722) #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyshen0722 merged 2 commits into from
Oct 31, 2026
+8 −0
Merged

test(mentions): owner mentioning their own never-connected agent gets the line (TASK-722) #3111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f940a55
test(mentions): the owner mentioning their own never-connected agent …
lilyshen0722 Oct 31, 2026
c1b98b8
test(mentions): fix quote in owner-mention test title (TASK-722)
lilyshen0722 Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions backend/__tests__/unit/services/neverConnectedMentionService.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,14 @@ it('posts one not-connected line when a person mentions a BYO agent that never p
});
});

it('posts the line when the owner is the one who mentions it (TASK-722)', async () => {
const posted = await noteNeverConnectedMention({ ...args, senderId: byoInstall.installedBy });

expect(posted).toBe(true);
expect(mockEmitNotConnected).toHaveBeenCalledTimes(1);
expect(mockEmitNotConnected.mock.calls[0][0]).toMatchObject({ agentKey: 'nova:default', messageId: '555' });
});

it('stays silent for a bot sender', async () => {
mockFindUser.mockReturnValue(chain({ isBot: true }));
expect(await noteNeverConnectedMention(args)).toBe(false);
Expand Down
Loading