[lilyshen0722]

Staging-smoke has been red on every deploy since #3143. That PR rebuilt the Connectors page from rows into a tile grid, and the smoke's connectors fold check still looked for .v2-connector-row. It found 0 rows and failed (visible=[] rows=0 foldedRows=0). The page itself is fine. This PR moves the check onto the new markup and keeps what it guards.

What the check does now

1. It looks at the tool tiles in the Tools group, skipping the add tile and dimmed tiles. A dimmed tile is something not offered that shows only after "+N off" is opened, so this keeps the old rule that the fold doesn't count.
2. For each shown tile that names a known tool, it opens the tile's reveal and looks for a Connect or Install button.
3. It passes once one tile has one.

The tile alone isn't enough. A tool can be shown and still offer only "Ask", or need an admin (GitHub for a non-admin). The old check had the same rule about the action, and this keeps it. The detail line now reads connectable=[…] shown=[…] off=<"+N off" or none>.

Checked against live staging at 1440, with the same logic, signed in as the non-admin seed seat:

• passes: connectable=[Atlassian,Airtable,Sentry,Notion] shown=[GitHub,Linear,Atlassian,Airtable,Sentry,Notion]
• GitHub's reveal has no Connect for a non-admin, and Linear's says "Add" because that account already holds a connection. Neither counts, so the check still tells the cases apart.
• Escape closes each reveal before the next tile opens.

The fresh-account credentials live only in CI secrets, so the real run is the next Deploy Staging after this merges.

Tier 0 (test script only).

🤖 Generated with Claude Code

https://claude.ai/code/session_015AKgpQmb6BbxDrAtw45bgN

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Team-Commonly/commonly
• Branch: stack/smoke-connector-tiles
• File: .coderabbit.yaml
• Commit: 93d9f85
• Layers: Repository YAML
• Review profile: QUIET
• Plan: Advanced
• Run ID: 8a84193b-ac17-4dbc-ad03-a5590a604c33

Commits

Reviewing files that changed from the base of the PR and between 99d8b61 and 93d9f85.

Files selected for processing: 1

• scripts/staging-smoke/staging-smoke.mjs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

Walkthrough

The staging smoke check now uses an English-locale browser context to inspect Tools tiles. It opens eligible tiles and checks for a non-secondary Connect or Install button in the dialog. Results include connectable and shown tool names and the off-fold label.

Changes: Tools smoke check

Layer / File(s)	Summary
Tools tile reveal check scripts/staging-smoke/staging-smoke.mjs	The check now scans visible, non-add, non-dim Tools tiles with known names and opens candidates to check their dialogs for a non-secondary Connect or Install button. It reports connectable and shown tool names and the off-fold label.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

• Team-Commonly/commonly#3143: Replaces the Connectors page with tile and reveal markup that the updated smoke check inspects.
• Team-Commonly/commonly#2507: Adds the staging check for a connectable tool outside the inactive fold, which this change updates.

Merge Risk: Minimal · up to 93d9f

This updates the staging smoke check to use the new Tools tile-grid markup. It affects only the post-deploy promotion check, not production behavior. No merge-blocking issue was found. The first fresh-account run will happen on the next staging deploy.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly identifies the staging smoke test change: it updates the check for connector tiles and their reveal after the rebuild.
Description check		The description directly explains why the smoke check failed, how it now handles tool tiles, and how connectable actions are detected.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[lilyshen0722]

Gate at 93d9f85 (Tier 0: smoke script only).

Checked:

• The new selectors match #3143's markup: the Tools group section.v2-cx-group, .v2-cx-tile with --add/--dim, the .v2-cx-pop[role=dialog] reveal, and .v2-connector-row__action (Ask is the --secondary link).
• The fold is still excluded. Folded tiles render only when "+N off" is open, and then as --dim.
• The pass needs a Connect or Install button in a reveal. "Add", "Ask" and "Disconnect" don't match.
• Live staging run of the same logic at 1440 passes: connectable Atlassian, Airtable, Sentry, Notion. GitHub (non-admin, no Connect) and Linear ("Add") are correctly not counted.
• Subagent review: locale and a fixed sleep. Both fixed at this head, and re-run green.
• CI green; CodeRabbit left no inline threads.

GATE: PASS