Repository navigation
ci(walk): parse fix for staging-e2e-walk (TASK-728) - #3161
Conversation
…(TASK-728) runner.temp is not available in a job-level env block, so GitHub refused every dispatch with HTTP 422. The walk step now sets COMMONLY_WALK_STATE_DIR. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Co-authored-by: rivet <WyJyaXZldCIsImRlZmF1bHQiXQ@agents.commonly.invalid> Agent-Model: claude/claude-haiku-5-5/default
lilyshen0722
left a comment
lilyshen0722
left a comment
There was a problem hiding this comment.
HEAD: 8e36594 — GATE: PASS
Reviewed the one-file diff at this head. The only change moves COMMONLY_WALK_STATE_DIR from the job-level env (where runner.* is not allowed) to the walk step's env. No other runner.* reference sits in the job env, and the upload-artifact path was already at step level. The YAML parses under js-yaml. actionlint is not installed here, so a real dispatch is the remaining proof.
Written by Rivet, a Commonly agent.
GATE: PASS
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Scope walk state directory to the step .github/workflows/staging-e2e-walk.yml |
The workflow removes the job-level COMMONLY_WALK_STATE_DIR setting and sets the same directory on the Walk staging step. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Possibly related PRs
- Team-Commonly/commonly#3150: Adds the staging workflow that this change updates.
- Team-Commonly/commonly#3145: Adds the
COMMONLY_WALK_STATE_DIRcontract used by the workflow.
Merge Risk: 
8e365
-
The workflow change is statically consistent and ready to merge; runtime dispatch validation remains optional operational follow-up.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly identifies the CI workflow parsing fix and includes the relevant task identifier. Description check The description directly explains the workflow parsing failure, the environment-scope fix, and the validation performed. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Fixes the TASK-728 P0:
staging-e2e-walk.ymlon main did not parse. The job-levelenv:usedrunner.temp, which GitHub does not allow there, so every dispatch was refused with HTTP 422 (Unrecognized named-value: 'runner', line 34).The fix moves
COMMONLY_WALK_STATE_DIRonto the walk step's ownenv:. The upload-artifact path already sat at step level and is unchanged.Validation: parsed the file with js-yaml; no
runner.*reference remains in the job-level env. actionlint is not installed on this host, so the parse check and the step-level grep are the validation so far. A real dispatch on staging is the proof, and SRE runs it.Written by Rivet, a Commonly agent.
🤖 Generated with Claude Code