Skip to content

test(v2): pin the fix-command row's flex and wrap rules - #3247

Merged
lilyshen0722 merged 1 commit into
mainfrom
launch/r07-command-row-guard
Nov 1, 2026
Merged

lilyshen0722 merged 1 commit into
mainfrom
launch/r07-command-row-guard

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Follow-up to #3241, which was already in the merge queue when CodeRabbit asked for this guard.

The never-connected room shows the fix command in a row with a copy key. A long command has to shrink and wrap inside that row instead of pushing the copy key out of the pane. This pins the four rules that keep it that way: display: flex on the row, plus flex: 1, min-width: 0 and overflow-wrap: anywhere on the code.

Test-only. Reverse-verified: with overflow-wrap: anywhere changed to normal, "direct-agent liveness stays above the composer as a stable, readable row" fails. Restored, v2-layout-invariants passes 323/323.

🤖 Generated with Claude Code

https://claude.ai/code/session_015AKgpMD6Qh13f7fj6mbGT3

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between d59c08b and ef28fce.

Files selected for processing: 1
  • frontend/src/v2/__tests__/v2-layout-invariants.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

Walkthrough

The direct-agent status layout invariant test now checks that the agent-room command uses flex layout and that its code element can shrink and wrap anywhere.

Changes: Agent-room command layout

Layer / File(s) Summary
Layout invariant coverage
frontend/src/v2/__tests__/v2-layout-invariants.test.ts
The test asserts that .v2-chat__agent-room-command uses display: flex. It also checks that its code element has flex: 1, min-width: 0, and overflow-wrap: anywhere.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related issues

Possibly related PRs

  • Team-Commonly/commonly#3241 — That PR adds the direct-agent fix-command row and its flex and wrapping CSS. This PR adds tests for those layout rules.
Merge Risk: Minimal · up to ef28f

The focused layout assertions align with the stated behavior and are safe to merge.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the test change that pins the fix-command row's flex and wrap rules.
Description check Passed The description directly explains the added test coverage, the four CSS rules, and the expected behavior for long commands.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fresh-context review (Haiku, test-only, Tier 0) at ef28fce. No defects.

  • Both selectors exist once each in chat/chat-states.css, with the four declarations the test pins.
  • readV2Css() joins v2.css with the chat sheets, chat-states.css included, so ruleBody reads the right text.
  • v2-layout-invariants passes 323/323.
  • Reverse-verified by the writer: with overflow-wrap: anywhere set to normal, the test fails.

GATE: PASS

@lilyshen0722
lilyshen0722 added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit 1c0b4b1 Nov 1, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant