Repository navigation
test(v2): pin the fix-command row's flex and wrap rules - #3247
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015AKgpMD6Qh13f7fj6mbGT3
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Layout invariant coverage frontend/src/v2/__tests__/v2-layout-invariants.test.ts |
The test asserts that .v2-chat__agent-room-command uses display: flex. It also checks that its code element has flex: 1, min-width: 0, and overflow-wrap: anywhere. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Possibly related issues
- board UX: no v2-native API-key/connect surface (verified), and a task-panel readability report from an external team #1400 — The PR adds test coverage for a command row that can wrap. The issue describes broader readability problems in the v2 task panel, which this PR does not fully address.
Possibly related PRs
- Team-Commonly/commonly#3241 — That PR adds the direct-agent fix-command row and its flex and wrapping CSS. This PR adds tests for those layout rules.
Merge Risk: 
Minimal · up to ef28f
-
The focused layout assertions align with the stated behavior and are safe to merge.
Pre-merge checks: 
4
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
lilyshen0722
commented
Nov 1, 2026
lilyshen0722
left a comment
Contributor
Author
There was a problem hiding this comment.
Fresh-context review (Haiku, test-only, Tier 0) at ef28fce. No defects.
- Both selectors exist once each in
chat/chat-states.css, with the four declarations the test pins. readV2Css()joinsv2.csswith the chat sheets,chat-states.cssincluded, soruleBodyreads the right text.v2-layout-invariantspasses 323/323.- Reverse-verified by the writer: with
overflow-wrap: anywhereset tonormal, the test fails.
GATE: PASS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3241, which was already in the merge queue when CodeRabbit asked for this guard.
The never-connected room shows the fix command in a row with a copy key. A long command has to shrink and wrap inside that row instead of pushing the copy key out of the pane. This pins the four rules that keep it that way:
display: flexon the row, plusflex: 1,min-width: 0andoverflow-wrap: anywhereon the code.Test-only. Reverse-verified: with
overflow-wrap: anywherechanged tonormal, "direct-agent liveness stays above the composer as a stable, readable row" fails. Restored,v2-layout-invariantspasses 323/323.🤖 Generated with Claude Code
https://claude.ai/code/session_015AKgpMD6Qh13f7fj6mbGT3